-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable GPU support on all provisioned Android devices #1983
Comments
SDDMotivationGPU acceleration is a valuable improvement if can speed up overall execution on virtual devices. GoalProviding control over enabling/disabling GPU acceleration. Non-GoalConverting the existing devices without into devices with GPU acceleration API
DesignThe flank is currently able to create or reuse the required amount of devices just before the test execution. Partial supportThe partial support will work correctly for the case where the virtual devices weren't created previously. Implementation can be described in the following steps:
The drawback is the partial support doesn't update already created virtual devices for Full supportBefore implementing full support could be necessary to make a decision what is the best way for managing the virtual devices for testing in the project scope which isn't a trivial problem. Specifying real use-cases and collecting requirements from the end-users will be extremely helpful. Explaining a complete solution for the full support is not in the scope of this document and should be treated as separated issue. blocked by #1984 |
Fixes #1983 ## Test Plan > How do we know the code works? 1. Remove previously created virtual devices in Corellium project. 2. Run `flank corellium test android run -c="./flank_corellium.yml"` 3. Check the newly created devices have enabled GPU acceleration * Debug `RunTestAndroidCorelliumExample` and check `flank.corellium.adapter.getCreatedInstances` are returning instances with properly configured `BootOptions`| * Or find another way for checking if GPU acceleration is enabled. ## Checklist - [x] Documented - [x] Unit tested
Enable GPU support on all provisioned Android devices so that the pilot companies get the best possible performance.
corellium/corellium-api@413858e
The text was updated successfully, but these errors were encountered: