Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add test file column to result table #1970

Merged
merged 3 commits into from
May 26, 2021
Merged

feat: Add test file column to result table #1970

merged 3 commits into from
May 26, 2021

Conversation

pawelpasterz
Copy link
Contributor

@pawelpasterz pawelpasterz commented May 26, 2021 •
edited
Loading

Fixes #1803

Test Plan

How do we know the code works?

  1. Run ./gradlew flankFullRun
  2. Run any flank test run (android/ios)
  3. Result table should have the TEST FILE column with the correct debug/xctest/json file name.

Checklist

  • Unit tested
  • IT updated

@pawelpasterz pawelpasterz self-assigned this May 26, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2021 •
edited
Loading

Timestamp: 2021-05-26 11:44:09
Buildscan url for ubuntu-workflow run 878367297

@pawelpasterz
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2021 •
edited
Loading

Integration tests succeed for all OSes ✅
Windows Build scan:
MacOS Build scan: https://gradle.com/s/bi7nuk3wq7peq
Linux Build scan: https://gradle.com/s/ju5xjm5mcbdu4
Workflow run https://github.com/Flank/flank/actions/runs/877695447

@pawelpasterz pawelpasterz marked this pull request as ready for review May 26, 2021 08:19
@pawelpasterz pawelpasterz enabled auto-merge (squash) May 26, 2021 08:19
@pawelpasterz pawelpasterz force-pushed the 1803-add-test-apk-column branch from 57f2eb0 to d881667 Compare May 26, 2021 11:37
@pawelpasterz pawelpasterz merged commit 6c6eb53 into master May 26, 2021
@pawelpasterz pawelpasterz deleted the 1803-add-test-apk-column branch May 26, 2021 14:20
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@piotradamczyk5 piotradamczyk5 piotradamczyk5 approved these changes

@Sloox Sloox Sloox approved these changes

Assignees

@pawelpasterz pawelpasterz

Labels
Bug P0 Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add column with test apk name in result table
3 participants
@pawelpasterz @Sloox @piotradamczyk5