-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add column with test apk name in result table #1803
Comments
The table is showing the app apk name. I agree showing the test apk instead may be more useful. |
Is it possible to have different app apk? I wasnt aware of that. test-apk name would be better as table shows result of test apk. |
Yes, you can define app - test app pair with Lines 295 to 301 in 475a124
Since flank supports the above feature, we can add additional column with test apk name Changing label to feature request since it is working as designed Dev note:
|
I can confirm Fulladle plugin only adds app-debug to top level and doesnt add additional app to tests. https://github.com/runningcode/fladle/blob/master/fladle-plugin/src/main/java/com/osacky/flank/gradle/FulladlePlugin.kt#L73 What is the usecase for adding different app apks? Different variant support or something like that? |
Some companies have multiple app apks and prefer to test them as a logical group. Typical use case doesn't need this feature. |
Even in that case, test apks need to have unique names. Printing test apk names would be much easier to spot which module has test fail. If using same test apk for different app is not possible, printing test apk name would be better in any case. |
I agree! Thanks for the feedback. |
Describe the bug
21.04.1
In result table, apk name is always app-debug.apk
To Reproduce
Expected behavior
Apk name column should show apk that used in that test run per module.
The text was updated successfully, but these errors were encountered: