Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: data scratch ios #1952

Merged
merged 15 commits into from
May 25, 2021
Merged

refactor: data scratch ios #1952

merged 15 commits into from
May 25, 2021

Conversation

Sloox
Copy link
Contributor

@Sloox Sloox commented May 20, 2021 •
edited
Loading

Fixes #1755

Test Plan

How do we know the code works?

Checklist

  • Unit tested
  • Integration tests updated

@Sloox Sloox self-assigned this May 20, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 20, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link
Contributor

github-actions bot commented May 20, 2021 •
edited
Loading

Timestamp: 2021-05-25 08:02:15
Buildscan url for ubuntu-workflow run 874064430
https://gradle.com/s/easff45z3mmlw

@Sloox Sloox marked this pull request as ready for review May 21, 2021 07:18
@bootstraponline bootstraponline force-pushed the 1755-data-scratch-ios branch from a35a4da to 8ef5df0 Compare May 21, 2021 13:25
@bootstraponline bootstraponline force-pushed the 1755-data-scratch-ios branch 3 times, most recently from f612e81 to 4d554e9 Compare May 24, 2021 08:54
@bootstraponline bootstraponline force-pushed the 1755-data-scratch-ios branch from 4d554e9 to fedbd70 Compare May 24, 2021 09:07
@Sloox Sloox requested a review from piotradamczyk5 May 24, 2021 11:23
@Flank Flank deleted a comment from github-actions bot May 24, 2021
@Flank Flank deleted a comment from adamfilipow92 May 24, 2021
@bootstraponline bootstraponline force-pushed the 1755-data-scratch-ios branch from fedbd70 to a264e7b Compare May 24, 2021 12:26
@Sloox
Copy link
Contributor Author

Sloox commented May 24, 2021

@flank-it

@Flank Flank deleted a comment from github-actions bot May 24, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2021 •
edited
Loading

Integration tests failed ❌
Windows status failure - Build scan:
MacOS status failure - Build scan:
Linux status failure - Build scan: https://gradle.com/s/2jpxa4zibqm5m
Workflow run https://github.com/Flank/flank/actions/runs/871419297

@pawelpasterz
Copy link
Contributor

pawelpasterz commented May 25, 2021 •
edited
Loading

https://gradle.com/s/2jpxa4zibqm5m

Tests failed due to quota limit, let's try again after limit is reset

@Flank Flank deleted a comment from github-actions bot May 25, 2021
@Sloox
Copy link
Contributor Author

Sloox commented May 25, 2021

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2021 •
edited
Loading

Integration tests succeed for all OSes ✅
Windows Build scan:
MacOS Build scan: https://gradle.com/s/i65ix55p2lqji
Linux Build scan: https://gradle.com/s/jvziqui6rrltq
Workflow run https://github.com/Flank/flank/actions/runs/874064820

@mergify mergify bot merged commit 19fac80 into master May 25, 2021
@mergify mergify bot deleted the 1755-data-scratch-ios branch May 25, 2021 10:09
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@piotradamczyk5 piotradamczyk5 piotradamczyk5 approved these changes

@pawelpasterz pawelpasterz pawelpasterz approved these changes

@adamfilipow92 adamfilipow92 Awaiting requested review from adamfilipow92

@zuziaka zuziaka Awaiting requested review from zuziaka

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

@jan-goral jan-goral Awaiting requested review from jan-goral

Assignees

@Sloox Sloox

Labels
Refactor Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data scratch - ios test matrix
3 participants
@Sloox @pawelpasterz @piotradamczyk5