Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data scratch - ios test matrix #1755

Closed
jan-goral opened this issue Mar 29, 2021 · 0 comments · Fixed by #1952
Closed

Data scratch - ios test matrix #1755

jan-goral opened this issue Mar 29, 2021 · 0 comments · Fixed by #1952

Comments

@jan-goral
Copy link
Contributor

Plan

According to the specification described in epic #1727
add abstraction and implementation for the following part of the data layer:

Abstraction

ftl/data/TestMatrixIos.kt

package ftl.data

val executeTestMatrixIos: TestMatrixIos.Execute get() = TODO()

object TestMatrixIos {

    data class Config(
        // args
        val clientDetails: Map<String, String>?,
        val networkProfile: String?,
        val directoriesToPull: List<String>,
        val testTimeout: String,
        val recordVideo: Boolean,
        val flakyTestAttempts: Int,
        val failFast: Boolean,
        val project: String,
        val resultsHistoryName: String?,

        // build
        val devices: List<Device>,
        val otherFiles: Map<String, String>,
        val additionalIpasGcsPaths: List<String>,
    )

    sealed class Type {
        data class XcTest(
            val xcTestGcsPath: String,
            val xcTestRunFileGcsPath: String,
            val xcodeVersion: String,
            val testSpecialEntitlements: Boolean,
            val matrixGcsPath: String,
        )

        data class GameLoop(
            val appGcsPath: String,
            val scenarios: List<Int>,
            val matrixGcsPath: String,
        )
    }

    interface Execute : (Config, Type) -> TestMatrix.Result
}

Target

  • IosRunCommand -> IosArgs/runIosTests -> GcIosTestMatrix/build
  • IosTestContext

Adapter

ftl/adapter/TestMatrixIos.kt

@Sloox Sloox assigned Sloox and unassigned Sloox Apr 26, 2021
@Sloox Sloox self-assigned this May 14, 2021
@Sloox Sloox mentioned this issue May 20, 2021
2 tasks
@mergify mergify bot closed this as completed in #1952 May 25, 2021
mergify bot pushed a commit that referenced this issue May 25, 2021
Fixes #1755 

## Test Plan
> How do we know the code works?

- Code is refactored according to description provided by #1755
- It takes into account work done on: #1941 and attempts to be as close as possible for consistency.

## Checklist

- [x] Unit tested
- [x] Integration tests updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants