feat: added max-test-shards and client-details to additional-app-test-apks #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
3 tasks
|
recheck |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
Sloox
requested review from
Sloox,
adamfilipow92,
jan-goral and
pawelpasterz
and removed request for
Sloox and
adamfilipow92
test_runner/src/main/kotlin/ftl/client/google/run/android/GcAndroidTestMatrix.kt
Outdated
Show resolved
Hide resolved
test_runner/src/main/kotlin/ftl/run/platform/android/CreateAndroidTestContext.kt
Outdated
Show resolved
Hide resolved
test_runner/src/main/kotlin/ftl/run/platform/android/CreateAndroidTestContext.kt
Outdated
Show resolved
Hide resolved
…roidTestContext.kt Co-authored-by: piotradamczyk5 <[email protected]>
piotradamczyk5
approved these changes
May 19, 2021
|
Thank you @asadsalman for your contribution 🎉 ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
This PR is a rework of #1898. A PR was merged recently which refactors some of the code I was using and introduced merge conflicts in #1898. This PR implements the same functionality with the refactored code.
This PR adds the ability to specify
max-test-shardsandclient-detailsfor tests under additional-app-test-apks like so:These configurations really improves support for multi-module projects, usually the thing I want to change the most is number of shards used to test a module. It also lets me differentiate between modules by setting key/values under
client-details.Test Plan
Checklist