-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
abandoned: feat: added max-test-shards and client-details to additional-app-test-apks #1898
Conversation
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA 1 out of 2 committers have signed the CLA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asadsalman Hey can you sign the CLA bot to continue? If you are having issues with it or cannot sign it for legal reasons, please open an issue and we will implement this change for you.
There also will most likely be failing tests. Could you run a./gradlew clean build
locally to ensure all is clear.
I have read the CLA Document and I hereby sign the CLA |
I wrote up this draft to get early feedback on this approach. If it looks reasonable to you, I'm happy to proceed with fixing tests/linting/doc updates etc. I based my approach on this PR. Let me know if I should proceed. |
cc @jan-gogo |
recheck |
…ank into asalman/additional-config2
Hey @asadsalman , please check slack in the firebase community, i have left you a direct message. |
recheck |
…ank into asalman/additional-config2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks good, thanks! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment, else it looks fine by me 👍
This PR is now implemented by #1947 since a recent refactor introduced merge conflicts and it was easier to reimplement this as a new PR instead of rebasing and including all those new commits in this PR too. |
Fixes #
This PR adds the ability to specify
max-test-shards
andclient-details
for tests underadditional-app-test-apks
like so:These configurations really improves support for multi-module projects, usually the thing I want to change the most is number of shards used to test a module. It also lets me differentiate between modules by setting key/values under
client-details
.Test Plan
Checklist