Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Part 2 of IT tests #1635

Merged
merged 4 commits into from
Feb 26, 2021
Merged

feat: Part 2 of IT tests #1635

merged 4 commits into from
Feb 26, 2021

Conversation

Sloox
Copy link
Contributor

@Sloox Sloox commented Feb 26, 2021 •
edited
Loading

Fixes #1553

Now handles 3 URLS

Checklist

  • Integration tests updated

@Sloox Sloox self-assigned this Feb 26, 2021
@Sloox
Copy link
Contributor Author

Sloox commented Feb 26, 2021

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2021 •
edited
Loading

Integration tests failed ❌
Windows status failure - Build scan:
MacOS status failure - Build scan: https://gradle.com/s/vps2a25jacddq
Linux status failure - Build scan: https://gradle.com/s/5vho2e6dqzyww
Workflow run https://github.com/Flank/flank/actions/runs/602028654

@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2021 •
edited
Loading

Timestamp: 2021-02-26 15:30:10
Buildscan url for ubuntu-workflow run 603156655
https://gradle.com/s/2vvz52wa3l5o6

@Sloox
Copy link
Contributor Author

Sloox commented Feb 26, 2021

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2021 •
edited
Loading

Integration tests succeed for all OSes ✅
Windows Build scan:
MacOS Build scan: https://gradle.com/s/rbig5d67i5oc6
Linux Build scan: https://gradle.com/s/k62yigj7is27s
Workflow run https://github.com/Flank/flank/actions/runs/602669286

pawelpasterz
pawelpasterz suggested changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@pawelpasterz pawelpasterz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update full_suite_integration_tests.yml

@Sloox Sloox requested a review from pawelpasterz February 26, 2021 15:08
@Sloox Sloox enabled auto-merge (squash) February 26, 2021 17:45
@Sloox Sloox disabled auto-merge February 26, 2021 17:46
@Sloox Sloox merged commit c685f57 into master Feb 26, 2021
@Sloox Sloox deleted the #1553-part-2-modification branch February 26, 2021 17:46
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zuziaka zuziaka zuziaka approved these changes

@jan-goral jan-goral jan-goral approved these changes

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

@adamfilipow92 adamfilipow92 Awaiting requested review from adamfilipow92

@piotradamczyk5 piotradamczyk5 Awaiting requested review from piotradamczyk5

@pawelpasterz pawelpasterz Awaiting requested review from pawelpasterz

Assignees

@Sloox Sloox

@pawelpasterz pawelpasterz

Labels
Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify Integration processResult to handle 3 URLs & 3 results
4 participants
@Sloox @zuziaka @pawelpasterz @jan-goral