Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Integration processResult to handle 3 URLs & 3 results #1553

Closed
Sloox opened this issue Feb 2, 2021 · 2 comments · Fixed by #1624, #1626 or #1635
Closed

Modify Integration processResult to handle 3 URLs & 3 results #1553

Sloox opened this issue Feb 2, 2021 · 2 comments · Fixed by #1624, #1626 or #1635
Assignees
Milestone

Comments

@Sloox
Copy link
Contributor

Sloox commented Feb 2, 2021

processResult needs to be modified once the 3 urls have been passed to the correct locations. We also need to handle the 3 results correctly at this point.

@pawelpasterz pawelpasterz self-assigned this Feb 15, 2021
@Sloox Sloox self-assigned this Feb 15, 2021
@zuziaka zuziaka added this to the Sprint 2 milestone Feb 15, 2021
@pawelpasterz
Copy link
Contributor

pawelpasterz commented Feb 16, 2021

As discussed:

  1. process_result should expect 3 URL strings
  2. ...but none is required (URL can be empty)
  3. print URLs for failure message only
  4. all URLs in one comment
  5. print non-empty URL only

cc @Sloox

@pawelpasterz
Copy link
Contributor

Reopen - Mistakenly closed in #1624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment