Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Flank scripts features not depends on each other #1572

Merged
merged 2 commits into from
Feb 9, 2021
Merged

refactor: Flank scripts features not depends on each other #1572

merged 2 commits into from
Feb 9, 2021

Conversation

adamfilipow92
Copy link
Contributor

Fixes #1543

Test Plan

How do we know the code works?

The tests should pass. Scripts should work as before.

Checklist

  • Unit tested

@adamfilipow92 adamfilipow92 self-assigned this Feb 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2021 •
edited
Loading

Timestamp: 2021-02-09 14:45:17
Buildscan url for ubuntu-workflow run 551639648

Sloox
Sloox suggested changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this only a package name change?

@adamfilipow92
Copy link
Contributor Author

Is this only a package name change?

I was moving some functions to common package like AppendReleaseNotes.kt because is used in two other packages.

piotradamczyk5
piotradamczyk5 approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs some adjustments after merge #1574 , but for now the main goal is achieved 👍

@bootstraponline bootstraponline force-pushed the 1543-flank-scripts-features-not-depends-on-each-other branch from 8dc561b to 1b36311 Compare February 9, 2021 14:39
@Sloox Sloox self-requested a review February 9, 2021 15:34
Sloox
Sloox approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understand it now and approved: 🚀

@mergify mergify bot merged commit 830e8af into master Feb 9, 2021
@mergify mergify bot deleted the 1543-flank-scripts-features-not-depends-on-each-other branch February 9, 2021 15:34
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@piotradamczyk5 piotradamczyk5 piotradamczyk5 approved these changes

@Sloox Sloox Sloox approved these changes

@zuziaka zuziaka Awaiting requested review from zuziaka

@jan-goral jan-goral Awaiting requested review from jan-goral

@pawelpasterz pawelpasterz Awaiting requested review from pawelpasterz

Assignees

@adamfilipow92 adamfilipow92

Labels
Refactor Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make flank-scripts features not depends on each other
3 participants
@adamfilipow92 @Sloox @piotradamczyk5