Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactor CLI of Flank-scripts #1574

Merged
merged 5 commits into from
Feb 9, 2021

Conversation

piotradamczyk5
Copy link
Contributor

Fixes #1567

This PR refactor CLI layer of Flank scripts as described in command overview and SDD

Test Plan

How do we know the code works?

  1. Directories looks like:
├── cli
│   ├── Main.kt
│   ├── assemble
│   │   ├── AssembleCommand.kt
│   │   ├── FlankCommand.kt
│   │   ├── GoCommand.kt
│   │   ├── android
│   │   │   ├── AndroidCommand.kt
│   │   │   └── AppCommand.kt
│   │   └── ios
│   │       ├── EarlGreyCommand.kt
│   │       ├── ExampleCommand.kt
│   │       ├── FlankExampleCommand.kt
│   │       ├── FtlCommand.kt
│   │       ├── GameLoopExampleCommand.kt
│   │       ├── IosCommand.kt
│   │       ├── RunFtlLocalCommand.kt
│   │       └── TestPlansExample.kt
│   ├── dependencies
│   │   ├── DependenciesCommand.kt
│   │   ├── InstallXcPrettyCommand.kt
│   │   ├── SetupIosEnvCommand.kt
│   │   ├── UniversalFrameworkCommand.kt
│   │   ├── UpdateBinariesCommand.kt
│   │   └── UpdateCommand.kt
│   ├── firebase
│   │   ├── CheckForSdkUpdatesCommand.kt
│   │   ├── FirebaseCommand.kt
│   │   ├── GenerateClientCommand.kt
│   │   └── UpdateApiCommand.kt
│   ├── github
│   │   ├── CopyIssuePropertiesCommand.kt
│   │   ├── DeleteOldTagCommand.kt
│   │   ├── DeleteReleaseCommand.kt
│   │   ├── GitHubCommand.kt
│   │   └── MakeReleaseCommand.kt
│   ├── integrationtests
│   │   ├── IntegrationTestsCommand.kt
│   │   └── ProcessResultCommand.kt
│   ├── linter
│   │   ├── ApplyToGitHooksCommand.kt
│   │   ├── ApplyToIdeCommand.kt
│   │   └── LinterCommand.kt
│   ├── release
│   │   ├── DeleteSnapshotCommand.kt
│   │   ├── GenerateReleaseNotesCommand.kt
│   │   ├── NextTagCommand.kt
│   │   ├── ReleaseCommand.kt
│   │   └── SyncWithMavenCentralCommand.kt
│   └── testartifacts
│       ├── DownloadCommand.kt
│       ├── LinkCommand.kt
│       ├── PrepareCommand.kt
│       ├── RemoveRemoteCommand.kt
│       ├── ResolveCommand.kt
│       ├── TestArtifactsCommand.kt
│       ├── UnzipCommand.kt
│       ├── UploadCommand.kt
│       └── ZipCommand.kt
  1. Command are named and used like described in docs/flank-scripts/command_overview.md

Checklist

  • Documented

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2021

Timestamp: 2021-02-09 15:43:22
Buildscan url for ubuntu-workflow run 551801772

Copy link
Contributor

@adamfilipow92 adamfilipow92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code looks good
  • Build works

👍

docs/flank-scripts/README.md Outdated Show resolved Hide resolved
docs/flank-scripts/README.md Outdated Show resolved Hide resolved
docs/flank-scripts/README.md Outdated Show resolved Hide resolved
docs/flank-scripts/README.md Outdated Show resolved Hide resolved
@piotradamczyk5 piotradamczyk5 force-pushed the #1567_refactor_flank-scripts_cli branch from 84b5825 to 0935baf Compare February 9, 2021 15:36
@piotradamczyk5 piotradamczyk5 merged commit f0f6b51 into master Feb 9, 2021
@piotradamczyk5 piotradamczyk5 deleted the #1567_refactor_flank-scripts_cli branch February 9, 2021 15:48
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement new flank-scripts commands structure and namings
3 participants