Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Update picocli to latest version #1473

Merged
merged 1 commit into from
Jan 11, 2021
Merged

refactor: Update picocli to latest version #1473

merged 1 commit into from
Jan 11, 2021

Conversation

piotradamczyk5
Copy link
Contributor

Fixes #1452
Picocli latest version causes that Flank does not work, it was caused by breaking changes that prevent the class to contain nested @Mixin annotated configuration classes.
It turns out that we do not need to change our logic of reading data in mutableMap<String, Any?>

Test Plan

How do we know the code works?

All tests passed.
Flank works normally

Checklist

  • Version update
  • Refactor of reading configuration

@piotradamczyk5 piotradamczyk5 self-assigned this Jan 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@piotradamczyk5
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2021 •
edited
Loading

Integration tests failed ❌
Build scan https://gradle.com/s/hfsr4ml7cbt2a
Workflow run https://github.com/Flank/flank/actions/runs/472222218

@piotradamczyk5
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2021 •
edited
Loading

Integration tests succeed ✅
Build scan https://gradle.com/s/eb5gc6dcqu2fq
Workflow run https://github.com/Flank/flank/actions/runs/472234500

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2021 •
edited
Loading

Timestamp: 2021-01-11 06:31:57
Buildscan url for ubuntu-workflow run 475158801

Sloox
Sloox approved these changes Jan 9, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

adamfilipow92
adamfilipow92 approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@adamfilipow92 adamfilipow92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mergify mergify bot merged commit 0138cf8 into master Jan 11, 2021
@mergify mergify bot deleted the #1452_update_picocli branch January 11, 2021 06:32
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2021
@zuziaka zuziaka added this to the Sprint -1 milestone Jan 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Sloox Sloox Sloox approved these changes

@adamfilipow92 adamfilipow92 adamfilipow92 approved these changes

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

@zuziaka zuziaka Awaiting requested review from zuziaka

@pawelpasterz pawelpasterz Awaiting requested review from pawelpasterz

@jan-goral jan-goral Awaiting requested review from jan-goral

Assignees

@pawelpasterz pawelpasterz

@piotradamczyk5 piotradamczyk5

Labels
Feature Tiger 🐯
Projects
None yet
Milestone
Sprint -1
Development

Successfully merging this pull request may close these issues.

Update picocli to latest version
5 participants
@piotradamczyk5 @Sloox @adamfilipow92 @zuziaka @pawelpasterz