Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update picocli to latest version #1452

Closed
piotradamczyk5 opened this issue Jan 4, 2021 · 2 comments · Fixed by #1473
Closed

Update picocli to latest version #1452

piotradamczyk5 opened this issue Jan 4, 2021 · 2 comments · Fixed by #1473
Assignees
@piotradamczyk5
Labels
Feature Tiger 🐯

Comments

@piotradamczyk5
Copy link
Contributor

piotradamczyk5 commented Jan 4, 2021 •
edited
Loading

Author the user story for this feature

As a Developer, I want to use the latest version of picocli so I can be up to date with this tool.

Describe the solution
picocli makes new release which has breaking API changes please update it in Flank
@piotradamczyk5 piotradamczyk5 mentioned this issue Jan 4, 2021
Merged
@piotradamczyk5
Copy link
Contributor Author

If this task requires a lot of work, think about rewriting CLI reader to use Clikt

@piotradamczyk5 piotradamczyk5 self-assigned this Jan 7, 2021
@bootstraponline
Copy link
Contributor

Clikt looks awesome

@piotradamczyk5 piotradamczyk5 mentioned this issue Jan 8, 2021
Merged
2 tasks
@mergify mergify bot closed this as completed in #1473 Jan 11, 2021
mergify bot pushed a commit that referenced this issue Jan 11, 2021
@piotradamczyk5
refactor: Update picocli to latest version (#1473)
0138cf8 
Fixes #1452 
Picocli latest version causes that Flank does not work, it was caused by breaking changes that prevent the class to contain nested `@Mixin` annotated configuration classes.
It turns out that we do not need to change our logic of reading data in `mutableMap<String, Any?>`

## Test Plan
> How do we know the code works?

All tests passed.
Flank works normally

## Checklist

- [x] Version update
- [x] Refactor of reading configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@piotradamczyk5 piotradamczyk5

Labels
Feature Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Update picocli to latest version Flank/flank
2 participants
@bootstraponline @piotradamczyk5