Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Rewrite pre-commit hook & ktlint apply to idea into Flank Scripts #1428

Merged
merged 14 commits into from
Jan 6, 2021
Merged

feat: Rewrite pre-commit hook & ktlint apply to idea into Flank Scripts #1428

merged 14 commits into from
Jan 6, 2021

Conversation

Sloox
Copy link
Contributor

@Sloox Sloox commented Dec 28, 2020 •
edited
Loading

Fixes #1423

Test Plan

How do we know the code works?

Tested for Windows.

Checklist

  • Documented

@Sloox Sloox self-assigned this Dec 28, 2020
@Sloox Sloox changed the title feat: Rewrite Flank Scripts feat: Rewrite PR-commit - Hooks & ktlint into Flank Scripts Dec 28, 2020
@github-actions github-actions bot added the Styling All styling changes label Dec 28, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 28, 2020 •
edited
Loading

Timestamp: 2021-01-05 17:39:00
Buildscan url for ubuntu-workflow run 463974416
https://gradle.com/s/sftc2yn76xayo

@Sloox Sloox changed the title feat: Rewrite PR-commit - Hooks & ktlint into Flank Scripts feat: Rewrite pre-commit hook & ktlint apply to idea into Flank Scripts Dec 29, 2020
@Sloox Sloox force-pushed the #1423-githooks-intellij-code-style branch from c1681ec to ad891fd Compare December 29, 2020 18:28
@Sloox Sloox marked this pull request as ready for review December 29, 2020 18:29
@Sloox Sloox mentioned this pull request Dec 30, 2020
Merged
2 tasks
@Sloox Sloox marked this pull request as draft December 30, 2020 10:32
@Sloox Sloox requested a review from pawelpasterz December 30, 2020 10:32
@Sloox Sloox force-pushed the #1423-githooks-intellij-code-style branch from e0db35a to 739b51f Compare December 31, 2020 13:03
@Sloox Sloox marked this pull request as ready for review December 31, 2020 13:04
@Sloox Sloox force-pushed the #1423-githooks-intellij-code-style branch from cf693a0 to 0444b9b Compare January 4, 2021 08:26
@bootstraponline bootstraponline force-pushed the #1423-githooks-intellij-code-style branch from 0444b9b to 8629d6e Compare January 4, 2021 12:08
@Sloox Sloox requested a review from piotradamczyk5 January 4, 2021 12:19
@bootstraponline bootstraponline force-pushed the #1423-githooks-intellij-code-style branch from 8629d6e to c0d7fce Compare January 4, 2021 17:07
@adamfilipow92
Copy link
Contributor

I try to test how pre-commit hook works.

  1. Add unused import to ValidateIosArgs.kt
  2. Commit changes
  3. Pre-commit hooks works 👍
  4. I can see in committed changes this unused import
  5. In uncommitted changes I have ValidateIosArgs.kt with removed import

Maybe it's should commit files changed by ktlint? I'm not sure how it works before. WDYT?

@Sloox
Copy link
Contributor Author

Sloox commented Jan 5, 2021

I try to test how pre-commit hook works.

  1. Add unused import to ValidateIosArgs.kt
  2. Commit changes
  3. Pre-commit hooks works 👍
  4. I can see in committed changes this unused import
  5. In uncommitted changes I have ValidateIosArgs.kt with removed import

Maybe it's should commit files changed by ktlint? I'm not sure how it works before. WDYT?

@adamfilipow92 can you explain a bit more what you mean i am confused.

@bootstraponline bootstraponline force-pushed the #1423-githooks-intellij-code-style branch 2 times, most recently from 6370489 to 8b01b1c Compare January 5, 2021 10:49
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@bootstraponline bootstraponline force-pushed the #1423-githooks-intellij-code-style branch from 8b01b1c to f5c3500 Compare January 5, 2021 12:34
jan-goral
jan-goral reviewed Jan 5, 2021
View reviewed changes
docs/onboarding/1_environment_setup.md Outdated Show resolved Hide resolved
docs/onboarding/1_environment_setup.md Outdated Show resolved Hide resolved
docs/onboarding/1_environment_setup.md Outdated Show resolved Hide resolved
@Sloox Sloox requested a review from jan-goral January 5, 2021 17:33
@mergify mergify bot merged commit 971f32b into master Jan 6, 2021
@mergify mergify bot deleted the #1423-githooks-intellij-code-style branch January 6, 2021 05:47
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@piotradamczyk5 piotradamczyk5 piotradamczyk5 approved these changes

@pawelpasterz pawelpasterz pawelpasterz approved these changes

@adamfilipow92 adamfilipow92 Awaiting requested review from adamfilipow92

@zuziaka zuziaka Awaiting requested review from zuziaka

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

@jan-goral jan-goral Awaiting requested review from jan-goral

Assignees

@Sloox Sloox

Labels
Feature Styling All styling changes Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-write GitHooks and Ktlint to FlankScripts
6 participants
@Sloox @adamfilipow92 @bootstraponline @pawelpasterz @jan-goral @piotradamczyk5