-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 1422 autodetect new gcloud features #1436
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timestamp: 2020-12-31 09:34:48 |
05e7ecf
to
a3ffe27
Compare
Sloox
suggested changes
Dec 30, 2020
flank-scripts/src/main/kotlin/flank/scripts/shell/firebase/sdk/CheckForSDKUpdateCommand.kt
Outdated
Show resolved
Hide resolved
flank-scripts/src/main/kotlin/flank/scripts/shell/firebase/sdk/OpenedUpdates.kt
Show resolved
Hide resolved
flank-scripts/src/main/kotlin/flank/scripts/zenhub/ZenHubAPI.kt
Outdated
Show resolved
Hide resolved
flank-scripts/src/main/kotlin/flank/scripts/zenhub/ZenHubAPI.kt
Outdated
Show resolved
Hide resolved
Title does not follow the guidelines of Conventional Commits.
|
flank-scripts/src/main/kotlin/flank/scripts/shell/firebase/sdk/CheckForSDKUpdateCommand.kt
Outdated
Show resolved
Hide resolved
flank-scripts/src/main/kotlin/flank/scripts/shell/firebase/sdk/CommitList.kt
Outdated
Show resolved
Hide resolved
flank-scripts/src/main/kotlin/flank/scripts/shell/firebase/sdk/CheckForSDKUpdateCommand.kt
Show resolved
Hide resolved
flank-scripts/src/main/kotlin/flank/scripts/shell/firebase/sdk/Extensions.kt
Outdated
Show resolved
Hide resolved
piotradamczyk5
approved these changes
Dec 31, 2020
ed29f2b
to
bc695cf
Compare
Sloox
approved these changes
Dec 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1422
TLDR;
Fetch and parse
gcloud SDK
release notes to find new features/changes. If there are any -- create an epic with each new feature/change as a separate issue.What it actually does?
VERSION
file) based on commitsnew
==old
-- no updates, exit processRELEASE_NOTES
file from the current masternew
(included) tillold
(excluded)Firebase Test Lab
changes only*
is considered as a separate change/feature)Example issue: pawelpasterz#107
Test Plan
Again, it's a bit tricky to test implementation. (As promised, it will be refactored)
You need to have:
Preparation:
flank/flank-scripts/src/main/kotlin/flank/scripts/zenhub/ZenHubAPI.kt
Line 13 in d181427
flank/flank-scripts/src/main/kotlin/flank/scripts/github/GithubApi.kt
Line 35 in d181427
gcloud SDK
label in your repo (might be not required, github can handle new labels somehow(?) )./gradlew assemble
java -jar ./flank-scripts/build/libs/flank-scripts.jar shell firebase checkForSdkUpdate --github-token=[github token] --zenhub-token=[zenhub token]
No new commits
2020-09-16T04:09:10Z
2020-10-16T04:09:10Z
Checklist