fix: Print args when iOS tests are not found

integration_tests/src/test/kotlin/integration/AllTestFilteredIT.kt

@@ -3,7 +3,6 @@ package integration
 import FlankCommand
 import com.google.common.truth.Truth.assertThat
 import org.junit.Assume.assumeFalse
-import org.junit.Ignore
 import run
 import org.junit.Test
 
@@ -30,7 +29,6 @@ class AllTestFilteredIT {
     }
 
     @Test
-    @Ignore("Should be fixed in https://github.com/Flank/flank/issues/1388")
     fun `filter all tests - ios`() {
         assumeFalse(isWindows)
         val name = "$name-ios"
@@ -43,7 +41,7 @@ class AllTestFilteredIT {
             testSuite = name
         )
 
-        assertExitCode(result, 0)
+        assertExitCode(result, 1)
 
         val resOutput = result.output.removeUnicode()
         assertThat(resOutput).containsMatch(findInCompare(name))

integration_tests/src/test/resources/compare/AllTestFilteredIT-ios-compare

@@ -56,25 +56,5 @@ Found xctest: [0-9a-zA-Z\/_.-]*/test_runner/src/test/kotlin/ftl/fixtures/tmp/ios
 isMacOS = true \(mac os x\)
 nm -U "[0-9a-zA-Z\/_.-]*/test_runner/src/test/kotlin/ftl/fixtures/tmp/ios/EarlGreyExample/Debug-iphoneos/EarlGreyExampleSwift.app/PlugIns/EarlGreyExampleSwiftTests.xctest/EarlGreyExampleSwiftTests"
 nm -gU "[0-9a-zA-Z\/_.-]*/test_runner/src/test/kotlin/ftl/fixtures/tmp/ios/EarlGreyExample/Debug-iphoneos/EarlGreyExampleSwift.app/PlugIns/EarlGreyExampleSwiftTests.xctest/EarlGreyExampleSwiftTests" | xargs -s 262144 xcrun swift-demangle
-Saved 0 shards to ios_shards.json
-  Uploading ios_shards.json \.*
-  Uploading earlgrey_example.zip \*.
-  0 test / 0 shard
 
-  0 matrix ids created in \d{1,2}m \d{1,2}s
-  https://console.developers.google.com/storage/browser/test-lab-[a-zA-Z0-9_-]*/[.a-zA-Z0-9_-]*
-
-Matrices webLink
-
-
-CostReport
-  No cost. 0m
-
-  Uploading CostReport.txt \.*
-MatrixResultsReport
-  0 / 0 \(NaN\%\)
-  Uploading MatrixResultsReport.txt \.*
-FetchArtifacts
-
-
-Matrices webLink
+Empty shards. Cannot match any method to \[.*\]

test_runner/src/main/kotlin/ftl/args/ValidateCommonArgs.kt

@@ -77,6 +77,6 @@ fun IArgs.checkResultsDirUnique() {
 }
 
 fun IArgs.checkDisableSharding() {
-    if (disableSharding && maxTestShards > 0)
+    if (disableSharding && maxTestShards > 1)
         logLn("WARNING: disable-sharding enabled with max-test-shards = $maxTestShards, Flank will ignore max-test-shard and disable sharding.")
 }

test_runner/src/main/kotlin/ftl/args/ValidateIosArgs.kt

@@ -4,7 +4,9 @@ import ftl.args.yml.Type
 import ftl.ios.IosCatalog
 import ftl.ios.IosCatalog.getSupportedVersionId
 import ftl.ios.xctest.common.mapToRegex
+import ftl.log.logLn
 import ftl.run.exception.FlankConfigurationError
+import ftl.run.exception.FlankGeneralError
 import ftl.run.exception.IncompatibleTestDimensionError
 
 fun IosArgs.validate() = apply {
@@ -95,7 +97,7 @@ private fun IosArgs.assertXcTestRunData() {
             .flatMap { it.values }
             .flatten()
 
-        if (filteredMethods.isEmpty()) throw FlankConfigurationError(
+        if (filteredMethods.isEmpty()) throw FlankGeneralError(
             "Empty shards. Cannot match any method to $testTargets"
         )
 
@@ -110,7 +112,7 @@ private fun IosArgs.assertXcTestRunData() {
                 }
             }
 
-            println("WARNING: cannot match test_targets: $notMatched")
+            logLn("WARNING: cannot match test_targets: $notMatched")
         }
     }
 }

test_runner/src/main/kotlin/ftl/cli/firebase/test/android/AndroidRunCommand.kt

@@ -6,6 +6,7 @@ import ftl.args.validate
 import ftl.cli.firebase.test.CommonRunCommand
 import ftl.config.FtlConstants
 import ftl.config.emptyAndroidConfig
+import ftl.log.logLn
 import ftl.mock.MockServer
 import ftl.run.ANDROID_SHARD_FILE
 import ftl.run.dumpShards
@@ -47,8 +48,10 @@ class AndroidRunCommand : CommonRunCommand(), Runnable {
             MockServer.start()
         }
 
-        AndroidArgs.load(Paths.get(configPath), cli = this).validate().run {
+        AndroidArgs.load(Paths.get(configPath), cli = this).apply {
             setupLogLevel()
+            logLn(this)
+        }.validate().run {
             runBlocking {
                 if (dumpShards) dumpShards()
                 else newTestRun()
@@ -62,3 +65,4 @@ class AndroidRunCommand : CommonRunCommand(), Runnable {
     )
     var dumpShards: Boolean = false
 }
+

test_runner/src/main/kotlin/ftl/cli/firebase/test/ios/IosRunCommand.kt

@@ -6,6 +6,7 @@ import ftl.args.validate
 import ftl.cli.firebase.test.CommonRunCommand
 import ftl.config.FtlConstants
 import ftl.config.emptyIosConfig
+import ftl.log.logLn
 import ftl.mock.MockServer
 import ftl.run.IOS_SHARD_FILE
 import ftl.run.dumpShards
@@ -47,8 +48,10 @@ class IosRunCommand : CommonRunCommand(), Runnable {
             MockServer.start()
         }
 
-        IosArgs.load(Paths.get(configPath), cli = this).validate().run {
+        IosArgs.load(Paths.get(configPath), cli = this).apply {
             setupLogLevel()
+            logLn(this)
+        }.validate().run {
             if (dumpShards) dumpShards()
             else runBlocking { newTestRun() }
         }

test_runner/src/main/kotlin/ftl/run/NewTestRun.kt

@@ -21,7 +21,6 @@ import kotlinx.coroutines.withTimeoutOrNull
 
 suspend fun IArgs.newTestRun() = withTimeoutOrNull(parsedTimeout) {
     val args: IArgs = this@newTestRun
-    logLn(args)
     val (matrixMap, testShardChunks, ignoredTests) =
         cancelTestsOnTimeout(project) { runTests() }
 

test_runner/src/main/kotlin/ftl/run/platform/RunIosTests.kt

@@ -45,9 +45,9 @@ internal suspend fun IosArgs.runIosTests(): TestResult =
         val otherGcsFiles = uploadOtherFiles()
         val additionalIpasGcsFiles = uploadAdditionalIpas()
 
-    dumpShards()
-    if (disableResultsUpload.not())
-        GcStorage.upload(IOS_SHARD_FILE, resultsBucket, resultsDir)
+        dumpShards()
+        if (disableResultsUpload.not())
+            GcStorage.upload(IOS_SHARD_FILE, resultsBucket, resultsDir)
 
         // Upload only after parsing shards to detect missing methods early.
         val xcTestGcsPath = uploadIfNeeded(xctestrunZip.asFileReference()).gcs