-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Print args when iOS tests are not found #1395
Conversation
Timestamp: 2020-12-15 12:53:51 |
Codecov Report
@@ Coverage Diff @@
## master #1395 +/- ##
============================================
- Coverage 77.31% 77.28% -0.03%
Complexity 719 719
============================================
Files 250 250
Lines 4831 4830 -1
Branches 922 922
============================================
- Hits 3735 3733 -2
- Misses 595 596 +1
Partials 501 501 |
606e7ce
to
0ccd96c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like the validation is split between execution steps. Wouldn't be better to print args before any validation instead of breaking validation consistency?
0ccd96c
to
a0d78ae
Compare
Agree |
+1 I think printing args (always) is a good idea. |
test_runner/src/main/kotlin/ftl/cli/firebase/test/android/AndroidRunCommand.kt
Outdated
Show resolved
Hide resolved
test_runner/src/main/kotlin/ftl/cli/firebase/test/ios/IosRunCommand.kt
Outdated
Show resolved
Hide resolved
test_runner/src/main/kotlin/ftl/cli/firebase/test/android/AndroidRunCommand.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears it will fix #1389
Fixes #1388
Test Plan
Checklist