Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing Command(collection module's TxCmdModify) #911

Merged
merged 2 commits into from
Feb 27, 2023
Merged

fix: add missing Command(collection module's TxCmdModify) #911

merged 2 commits into from
Feb 27, 2023

Conversation

jaeseung-bae
Copy link
Contributor

@jaeseung-bae jaeseung-bae commented Feb 23, 2023 •
edited
Loading

Description

  • Fix: add missing tx cmd for cli

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@codecov
Copy link

codecov bot commented Feb 23, 2023 •
edited
Loading

Codecov Report

Merging #911 (3983d80) into main (34c10e5) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #911   +/-   ##
=======================================
  Coverage   62.32%   62.32%           
=======================================
  Files         653      653           
  Lines       79443    79443           
=======================================
+ Hits        49515    49516    +1     
+ Misses      27249    27248    -1     
  Partials     2679     2679
Impacted Files Coverage Δ
crypto/keys/internal/ecdsa/privkey.go 83.01% <0.00%> (+1.88%) ⬆️

@jaeseung-bae jaeseung-bae marked this pull request as ready for review February 24, 2023 02:28
@jaeseung-bae jaeseung-bae self-assigned this Feb 24, 2023
0Tech
0Tech approved these changes Feb 27, 2023
View reviewed changes
Copy link
Collaborator

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the correction!

zemyblue
zemyblue approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good.

@jaeseung-bae jaeseung-bae merged commit bd1703f into Finschia:main Feb 27, 2023
@jaeseung-bae jaeseung-bae deleted the fix/missing-cmd branch February 27, 2023 06:31
zemyblue pushed a commit to zemyblue/finschia-sdk that referenced this pull request Mar 17, 2023
@jaeseung-bae @zemyblue
fix: add missing Command(collection module's TxCmdModify) (Finschia#911)
220083d
@zemyblue zemyblue mentioned this pull request Mar 17, 2023
Merged
5 tasks
zemyblue added a commit that referenced this pull request Mar 22, 2023
@zemyblue
Merge pull request #937 from zemyblue/backporting_main
8bb999d 
Backport main changes (#900, #911, #912, #922, #923, #934, #939, #933, #934, #938)
@zemyblue zemyblue mentioned this pull request Apr 24, 2023
Merged
@0Tech 0Tech mentioned this pull request Aug 1, 2023
Merged
4 tasks
@0Tech 0Tech added A: bug Something isn't working C:x/collection labels Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loin3 loin3 loin3 approved these changes

@dudong2 dudong2 dudong2 approved these changes

@0Tech 0Tech 0Tech approved these changes

@zemyblue zemyblue zemyblue approved these changes

Assignees

@jaeseung-bae jaeseung-bae

Labels
A: bug Something isn't working C:x/collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jaeseung-bae @zemyblue @0Tech @dudong2 @loin3