fix: propagate events in x/foundation through sdk.Results #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0Tech
force-pushed
the
foundation-exec-event
branch
from
6f44b7a to
716e5c7
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #922 +/- ##
=======================================
Coverage 62.36% 62.36%
=======================================
Files 655 655
Lines 79759 79763 +4
=======================================
+ Hits 49740 49745 +5
+ Misses 27335 27334 -1
Partials 2684 2684
|
jaeseung-bae
approved these changes
Mar 15, 2023
loin3
approved these changes
Mar 16, 2023
zemyblue
pushed a commit
to zemyblue/finschia-sdk
that referenced
this pull request
Mar 17, 2023
* Propagate events in x/foundation through sdk.Results * Update CHANGELOG.md (cherry picked from commit c025e91)
5 tasks
This was referenced Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch would propagate events correctly to the current context.
Motivation and context
The
x/foundationmodule does not propagate events correctly to the current context on itsMsgExec.The corresponding bug has been already fixed in the upstream.
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml