Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add MultiSend deactivation #876

Merged
merged 4 commits into from
Feb 6, 2023

Conversation

tkxkd0159
Copy link
Member

@tkxkd0159 tkxkd0159 commented Feb 2, 2023

Description

closes: #868

Activate this feature on bankpluskeeper directly instead of using config. Because this feature is not supposed to change by an outside party. It need to use intentionally when build an App instance.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #876 (177af73) into main (611b286) will decrease coverage by 0.01%.
The diff coverage is 80.00%.

❗ Current head 177af73 differs from pull request most recent head 6f323e6. Consider uploading reports for the commit 6f323e6 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #876      +/-   ##
==========================================
- Coverage   62.37%   62.37%   -0.01%     
==========================================
  Files         653      653              
  Lines       79976    79985       +9     
==========================================
+ Hits        49885    49890       +5     
- Misses      27399    27402       +3     
- Partials     2692     2693       +1     
Impacted Files Coverage Δ
x/bankplus/keeper/keeper.go 91.93% <78.57%> (-4.30%) ⬇️
simapp/app.go 82.30% <100.00%> (ø)
crypto/keys/internal/ecdsa/privkey.go 81.13% <0.00%> (-1.89%) ⬇️

x/bankplus/keeper/keeper.go Outdated Show resolved Hide resolved
@tkxkd0159 tkxkd0159 requested a review from 0Tech February 6, 2023 02:10
@tkxkd0159 tkxkd0159 merged commit a7557b1 into Finschia:main Feb 6, 2023
@tkxkd0159 tkxkd0159 deleted the deact-multisend branch February 6, 2023 03:04
@zemyblue
Copy link
Member

zemyblue commented Feb 6, 2023

@tkxkd0159 , unittest also should change.
https://github.com/line/lbm-sdk/blob/a7557b1d1029fcf9c112f3dc0cf94d158e197bc7/x/bankplus/keeper/keeper_test.go#L297-L299

zemyblue added a commit to zemyblue/finschia-sdk that referenced this pull request Feb 6, 2023
* main:
  feat!: add MultiSend deactivation (Finschia#876)
  chore(deps): Bump github.com/gogo/protobuf in /ics23/go (Finschia#816)
  fix: do not create account on x/token,collection (Finschia#866)
  fix!: update x/collection,token proto (Finschia#863)

# Conflicts:
#	CHANGELOG.md
@tkxkd0159 tkxkd0159 mentioned this pull request Feb 6, 2023
5 tasks
@tkxkd0159 tkxkd0159 self-assigned this Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not supporting MsgMultiSend of x/bank
4 participants