fix: do not create account on x/token,collection #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #866 +/- ##
==========================================
- Coverage 62.37% 62.36% -0.02%
==========================================
Files 653 653
Lines 79976 79951 -25
==========================================
- Hits 49885 49860 -25
Misses 27399 27399
Partials 2692 2692
|
My mistake. They works fine. |
0Tech
requested review from
jaeseung-bae,
dudong2,
loin3,
tkxkd0159 and
zemyblue
zemyblue
approved these changes
Jan 26, 2023
loin3
approved these changes
Jan 30, 2023
zemyblue
added a commit
to zemyblue/finschia-sdk
that referenced
this pull request
Feb 6, 2023
* main: feat!: add MultiSend deactivation (Finschia#876) chore(deps): Bump github.com/gogo/protobuf in /ics23/go (Finschia#816) fix: do not create account on x/token,collection (Finschia#866) fix!: update x/collection,token proto (Finschia#863) # Conflicts: # CHANGELOG.md
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not create account on x/token,collection.
Motivation and context
The target address which receives a token apparently cannot broadcast a tx because of its zero-balance. We should not create the corresponding account on mint and send logic.
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml