Skip to content

Commit

Permalink
fix: propagate events in x/foundation through sdk.Results (#922)
Browse files Browse the repository at this point in the history
* Propagate events in x/foundation through sdk.Results

* Update CHANGELOG.md

(cherry picked from commit c025e91)
  • Loading branch information
0Tech authored and zemyblue committed Mar 17, 2023
1 parent 524cf1f commit 6a35014
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
### Bug Fixes
* (swagger) [\#898](https://github.com/line/lbm-sdk/pull/898) fix a bug not added `lbm.tx.v1beta1.Service/GetBlockWithTxs` in swagger
* (x/collection) [\#911](https://github.com/line/lbm-sdk/pull/911) Add missing command(TxCmdModify) for CLI
* (x/foundation) [\#922](https://github.com/line/lbm-sdk/pull/922) Propagate events in x/foundation through sdk.Results

### Removed

Expand Down
7 changes: 6 additions & 1 deletion x/foundation/keeper/exec.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,18 @@ func (k Keeper) Exec(ctx sdk.Context, proposalID uint64) error {
// Caching context so that we don't update the store in case of failure.
ctx, flush := ctx.CacheContext()

if _, err = k.doExecuteMsgs(ctx, *proposal); err != nil {
if results, err := k.doExecuteMsgs(ctx, *proposal); err != nil {
proposal.ExecutorResult = foundation.PROPOSAL_EXECUTOR_RESULT_FAILURE
logs = fmt.Sprintf("proposal execution failed on proposal %d, because of error %s", proposalID, err.Error())
logger.Info("proposal execution failed", "cause", err, "proposalID", proposal.Id)
} else {
proposal.ExecutorResult = foundation.PROPOSAL_EXECUTOR_RESULT_SUCCESS
flush()

for _, res := range results {
// NOTE: The sdk msg handler creates a new EventManager, so events must be correctly propagated back to the current context
ctx.EventManager().EmitEvents(res.GetEvents())
}
}
}

Expand Down

0 comments on commit 6a35014

Please sign in to comment.