Ignore skipped steps in stage duration computation #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #14548: Fix intermediate deploy stage duration. |
johnkoehn
approved these changes
Oct 2, 2022
namoscato
deleted the
namoscato/sc-14548/fix-intermediate-deploy-stage-duration
branch
namoscato
added a commit
that referenced
this pull request
Oct 2, 2022
…ine into namoscato/sc-13901/configure-new-slack-deploy-notifications-schedule * 'main' of github.com:namoscato/action-slack-deploy-pipeline: Ignore skipped steps in stage duration computation (#27)
namoscato
added a commit
that referenced
this pull request
Oct 24, 2022
…ine into dependabot/npm_and_yarn/date-fns-2.29.3 * 'main' of github.com:namoscato/action-slack-deploy-pipeline: Support schedule event; expose event icon (#28) Ignore skipped steps in stage duration computation (#27) Omit commit message descriptions (#23) Move to Fieldguide organization (#20)
namoscato
added a commit
that referenced
this pull request
Oct 24, 2022
…ine into dependabot/npm_and_yarn/typescript-4.8.4 * 'main' of github.com:namoscato/action-slack-deploy-pipeline: Bump @actions/core from 1.9.1 to 1.10.0 (#25) Bump date-fns from 2.29.2 to 2.29.3 (#15) Support schedule event; expose event icon (#28) Ignore skipped steps in stage duration computation (#27)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intermediate stage duration still incorporates a
lastCompletedSlackStepwithin the current job as described in #11 (comment). This change excludes skipped steps from that set to mitigate this incorrect0 secondsduration.See List jobs for a workflow run response schema for other possible
conclusionvalues: