Ignore skipped steps in stage duration computation (#27)

Fieldguide · Oct 2, 2022 · b0fe81e · b0fe81e
1 parent ba800ae
commit b0fe81e
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/__tests__/message.test.ts b/src/__tests__/message.test.ts
@@ -323,7 +323,13 @@ describe('postMessage', () => {
                   steps: [
                     {
                       name: 'Post to Slack',
-                      completed_at: '2022-09-10T00:00:05.000Z'
+                      completed_at: '2022-09-10T00:00:05.000Z',
+                      conclusion: 'success'
+                    },
+                    {
+                      name: 'Post to Slack (skipped)',
+                      completed_at: '2022-09-10T00:00:06.000Z',
+                      conclusion: 'skipped'
                     },
                     {
                       name: 'Run namoscato/action-slack-deploy-pipeline',

diff --git a/src/github/types.ts b/src/github/types.ts
@@ -42,5 +42,5 @@ export interface CompletedJobStep extends JobStep {
 }
 
 export function isCompletedJobStep(step: JobStep): step is CompletedJobStep {
-  return Boolean(step.completed_at)
+  return Boolean(step.completed_at) && 'skipped' !== step.conclusion
 }