Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize rendering and keyboard smoothness #2493

Conversation

kesha-antonov
Copy link
Collaborator

@kesha-antonov kesha-antonov commented Apr 5, 2024

Hi

This PR should improve performance A LOT
There're also plenty of room for improvements left

Fixes #2191

Please give it a try here: "react-native-gifted-chat": "kesha-antonov/react-native-gifted-chat#43625da0ae36d983c339c0d79ae900c8778f5241"

Note that you need to change import to from 'react-native-gifted-chat/src'

2.mp4
1.mp4

@fukemy
Copy link

fukemy commented May 7, 2024

good job

@AounNaqvi173
Copy link

AounNaqvi173 commented Aug 9, 2024

hi there ,thanks for your contribution. I wanted to use your patch so i installed it but after installation this is the react-native-gifted-chat folder in node modules
image
how can i use your patch

@kesha-antonov
Copy link
Collaborator Author

hi there ,thanks for your contribution. I wanted to use your patch so i installed it but after installation this is the react-native-gifted-chat folder in node modules image how can i use your patch

Hi

It was fixed in this commit
87393fc

Try yarn install --check-files

@AounNaqvi173
Copy link

ok

@AounNaqvi173
Copy link

it works thanks , but i am facing an issue with my previous implementation for scroll to a message from reply message for which i used scrollToIndex , with this patch it is not that performant do you how can i do that , i mainly wanted to use the keyboard smoothness feature

@kesha-antonov
Copy link
Collaborator Author

it works thanks , but i am facing an issue with my previous implementation for scroll to a message from reply message for which i used scrollToIndex , with this patch it is not that performant do you how can i do that , i mainly wanted to use the keyboard smoothness feature

Sorry, idk
You can tweak my fork to make it work

@AounNaqvi173
Copy link

Okay thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Message not scroll smoothly when Keyboard open and close
3 participants