chore(lint): adds stricter eslint configs #2283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed several 'obvious' issues were not being picked up by linting. To help get to solving those problems I have extended the linting for react-native, supporting jest, prettier, jsx and using the airbnb defaults.
|
Fixed by #2493 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no functional change here, but it does prepare the lint to support future work.
I noticed several 'obvious' issues were not being picked up by linting.
To help get to solving those problems I have extended the linting for react-native, supporting jest, prettier, jsx and using the airbnb defaults.
The issues that should probably be considered are marked as 'FIXME' in the eslint config. There is at least one of the issues listed there occurring and I have made no qualitative assessment of whether they should be kept off or not. I have turned errors off for gifted-chat that do not makes sense for the library like
no-underscore-dangleand@typescript-eslint/no-explicit-any.