Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for new mitmdump version and server and proxy not deactivating when exiting the app #16

Merged
merged 16 commits into from
Apr 11, 2022

Conversation

erickjung
Copy link
Contributor

PR Details

  • Fixed the usage of new mitmdump v2 location, the app was looking for the older version yet
  • Fixed the execution of scripts when exiting the app, now they will be executed in sync mode to guarantee the expected result. This fixes a problem when you quit the app with proxy or server turned on and still keeps activated while not using mockingbird anymore.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

* Fix

- Handling inside mitmproxy's code the file descriptors limit to fix this issue

* Bridge

- Adding heartbeat to cleanup old connections

* App

- Removing old bridge and websocket's python code
- Embedding mitmdump binary with mockingbird bridge
- Improved process execution layer,
* Fix

- Handling inside mitmproxy's code the file descriptors limit to fix this issue

* Bridge

- Adding heartbeat to cleanup old connections

* App

- Removing old bridge and websocket's python code
- Embedding mitmdump binary with mockingbird bridge
- Improved process execution layer,
* Fix

- Handling inside mitmproxy's code the file descriptors limit to fix this issue

* Bridge

- Adding heartbeat to cleanup old connections

* App

- Removing old bridge and websocket's python code
- Embedding mitmdump binary with mockingbird bridge
- Improved process execution layer,
- removing swiftlint installation from workflow
@erickjung erickjung merged commit 2c4a7aa into Farfetch:master Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants