Fix for new mitmdump version and server and proxy not deactivating wh…

…en exiting the app (#16) * Server freezes sometimes and needs to be restarted (#2) * Fix - Handling inside mitmproxy's code the file descriptors limit to fix this issue * Bridge - Adding heartbeat to cleanup old connections * App - Removing old bridge and websocket's python code - Embedding mitmdump binary with mockingbird bridge - Improved process execution layer, * Server freezes sometimes and needs to be restarted (#2) * Fix - Handling inside mitmproxy's code the file descriptors limit to fix this issue * Bridge - Adding heartbeat to cleanup old connections * App - Removing old bridge and websocket's python code - Embedding mitmdump binary with mockingbird bridge - Improved process execution layer, * Server freezes sometimes and needs to be restarted (#2) * Fix - Handling inside mitmproxy's code the file descriptors limit to fix this issue * Bridge - Adding heartbeat to cleanup old connections * App - Removing old bridge and websocket's python code - Embedding mitmdump binary with mockingbird bridge - Improved process execution layer, * Fixes routing match for http method (#4) * - bumping release version 1.2.0 - removing swiftlint installation from workflow * Release update 1.3.0 * Updating logo * Release 1.4.0 * Fixing new version of mitmdump_mb and tasks that should execute when exiting the app
Farfetch · Apr 11, 2022 · 2c4a7aa · 2c4a7aa
1 parent 28b94e9
commit 2c4a7aa
Show file tree

Hide file tree

Showing 8 changed files with 55 additions and 45 deletions.
diff --git a/src/Mockingbird/AppDelegate.swift b/src/Mockingbird/AppDelegate.swift
@@ -27,7 +27,7 @@ class AppDelegate: NSObject, NSApplicationDelegate {
         AppStore.task.dispatch(TaskAction.initialize)
         ServerManager.shared.initialize()
 
-        AppStore.task.dispatch(TaskAction.stopAll)
+        AppStore.task.dispatch(TaskAction.stopAll(forceSync: false))
         ServerManager.shared.stop()
     }
 
@@ -41,7 +41,7 @@ class AppDelegate: NSObject, NSApplicationDelegate {
     func applicationWillTerminate(_ aNotification: Notification) {
 
         ServerManager.shared.stop()
-        AppStore.task.dispatch(TaskAction.stopAll)
+        AppStore.task.dispatch(TaskAction.stopAll(forceSync: true))
 
         NSApp.terminate(self)
     }

diff --git a/src/Mockingbird/Resources/Scripts/mitm_on.sh b/src/Mockingbird/Resources/Scripts/mitm_on.sh
@@ -1,7 +1,7 @@
 #!/bin/sh
 if [ -z "$2" ]
 then
-    ~/.mockingbird/mitmproxy/mitmdump_mb
+    ~/.mockingbird/mitmproxy/mitmdump_mbv2
 else
-    ~/.mockingbird/mitmproxy/mitmdump_mb --allow-hosts "$2"
+    ~/.mockingbird/mitmproxy/mitmdump_mbv2 --allow-hosts "$2"
 fi
diff --git a/src/Mockingbird/Resources/mitmdump_mb.zip b/src/Mockingbird/Resources/mitmdump_mb.zip
diff --git a/src/Mockingbird/Store/Task/Service/ProcessManager.swift b/src/Mockingbird/Store/Task/Service/ProcessManager.swift
@@ -14,18 +14,24 @@ final class ProcessManager {
 
     private var mitmProcess: Process?
 
-    func execute(process: ProcessType) {
+    func execute(process: ProcessType, forceSync: Bool = false) {
 
-        switch process {
+        if forceSync {
 
-        case .ipInfo:
+            ProcessTask.launch(process: process, callback: self)
 
-            ProcessTask.launchSync(process: process, callback: self)
+        } else {
 
-        default:
+            switch process {
+
+            case .ipInfo:
+
+                ProcessTask.launchBackgroundSync(process: process, callback: self)
+
+            default:
 
-            ProcessTask.launchAsync(process: process,
-                                    callback: self)
+                ProcessTask.launchBackgroundAsync(process: process, callback: self)
+            }
         }
     }
 }

diff --git a/src/Mockingbird/Store/Task/Service/ProcessTask.swift b/src/Mockingbird/Store/Task/Service/ProcessTask.swift
@@ -42,44 +42,48 @@ enum ProcessType {
 
 class ProcessTask {
 
-    static func launchSync(process: ProcessType, callback: ProcessTaskCallback?) {
+    static func launch(process: ProcessType, callback: ProcessTaskCallback?) {
 
         guard let script = Bundle.main.path(forResource: process.script, ofType: "sh") else { return }
 
-        DispatchQueue.global(qos: .background).async {
+        callback?.processStarted(process)
 
-            callback?.processStarted(process)
+        let stdoutPipe = Pipe()
+        let stderrPipe = Pipe()
 
-            let stdoutPipe = Pipe()
-            let stderrPipe = Pipe()
+        let task = Process()
+        task.launchPath = "/bin/sh"
+        task.arguments = [script, (script as NSString).deletingLastPathComponent]
+        task.standardOutput = stdoutPipe
+        task.standardError = stderrPipe
 
-            let task = Process()
-            task.launchPath = "/bin/sh"
-            task.arguments = [script, (script as NSString).deletingLastPathComponent]
-            task.standardOutput = stdoutPipe
-            task.standardError = stderrPipe
+        task.launch()
+        task.waitUntilExit()
 
-            task.launch()
-            task.waitUntilExit()
+        if let stdoutText = String(data: stdoutPipe.fileHandleForReading.readDataToEndOfFile(), encoding: String.Encoding.utf8),
+           stdoutText.count > 0 {
 
-            if let stdoutText = String(data: stdoutPipe.fileHandleForReading.readDataToEndOfFile(), encoding: String.Encoding.utf8),
-               stdoutText.count > 0 {
+            callback?.stdoutUpdated(process, text: stdoutText)
+        }
 
-                callback?.stdoutUpdated(process, text: stdoutText)
-            }
+        if let stderrText = String(data: stderrPipe.fileHandleForReading.readDataToEndOfFile(), encoding: String.Encoding.utf8),
+           stderrText.count > 0 {
 
-            if let stderrText = String(data: stderrPipe.fileHandleForReading.readDataToEndOfFile(), encoding: String.Encoding.utf8),
-               stderrText.count > 0 {
+            callback?.stderrUpdated(process, text: stderrText)
+        }
 
-                callback?.stderrUpdated(process, text: stderrText)
-            }
+        callback?.processEnded(process)
+    }
 
-            callback?.processEnded(process)
+    static func launchBackgroundSync(process: ProcessType, callback: ProcessTaskCallback?) {
+
+        DispatchQueue.global(qos: .background).async {
+
+            Self.launch(process: process, callback: callback)
         }
     }
 
-    static func launchAsync(process: ProcessType,
-                            callback: ProcessTaskCallback?) {
+    static func launchBackgroundAsync(process: ProcessType, callback: ProcessTaskCallback?) {
 
         guard let script = Bundle.main.path(forResource: process.script, ofType: "sh") else { return }
 

diff --git a/src/Mockingbird/Store/Task/TaskActions.swift b/src/Mockingbird/Store/Task/TaskActions.swift
@@ -12,7 +12,7 @@ enum TaskAction: Action {
 
     case initialize
     case startAll
-    case stopAll
+    case stopAll(forceSync: Bool)
     case startProxy(isWifi: Bool)
     case stopProxy
     case startMitm

diff --git a/src/Mockingbird/Store/Task/TaskReducer.swift b/src/Mockingbird/Store/Task/TaskReducer.swift
@@ -31,9 +31,9 @@ class TaskReducer {
 
             Self.startAll(with: &state)
 
-        case .stopAll:
+        case .stopAll(let forceSync):
 
-            Self.stopAll(with: &state)
+            Self.stopAll(with: &state, forceSync: forceSync)
 
         case .startProxy(let isWifi):
 
@@ -91,10 +91,10 @@ private extension TaskReducer {
         Self.startProxy(with: &state)
     }
 
-    static func stopAll(with state: inout TaskState) {
+    static func stopAll(with state: inout TaskState, forceSync: Bool = false) {
 
-        Self.stopProxy(with: &state)
-        Self.stopMitm(with: &state)
+        Self.stopProxy(with: &state, forceSync: forceSync)
+        Self.stopMitm(with: &state, forceSync: forceSync)
     }
 
     static func startProxy(with state: inout TaskState, isWifi: Bool = false) {
@@ -106,12 +106,12 @@ private extension TaskReducer {
         ProcessManager.shared.execute(process: .ipInfo)
     }
 
-    static func stopProxy(with state: inout TaskState) {
+    static func stopProxy(with state: inout TaskState, forceSync: Bool = false) {
 
         state.isProxyEnabled = false
         state.ipInfo = ""
 
-        ProcessManager.shared.execute(process: .proxyOff)
+        ProcessManager.shared.execute(process: .proxyOff, forceSync: forceSync)
     }
 
     static func startMitm(with state: inout TaskState) {
@@ -121,10 +121,10 @@ private extension TaskReducer {
         ProcessManager.shared.execute(process: .mitmOn(currentContext: ContextManager.shared.currentContext))
     }
 
-    static func stopMitm(with state: inout TaskState) {
+    static func stopMitm(with state: inout TaskState, forceSync: Bool = false) {
 
         state.isMitmEnabled = false
 
-        ProcessManager.shared.execute(process: .mitmOff)
+        ProcessManager.shared.execute(process: .mitmOff, forceSync: forceSync)
     }
 }
diff --git a/src/Mockingbird/Utils/Default.swift b/src/Mockingbird/Utils/Default.swift
@@ -25,7 +25,7 @@ final class Default {
     public enum Folder {
 
         static var main = "/Users/" + NSUserName() + "/.mockingbird"
-        static var mitm: String { main + "/mitmproxy-v2" }
+        static var mitm: String { main + "/mitmproxy" }
         static var capture: String { workingDirectory + "/capture" }
         static var record: String { workingDirectory + "/record" }
         static var data: String { workingDirectory + "/data" }