This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
fix(plugin-runner-jest): Prepare plugin to deal with projects that has more than one projects #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s more than one projects
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we start using garment for running our playwright integration test, we found that the logic behind the config object was not ready to deal with jestConfig with more than one projects. The main reason is when we have more then one projects the configuration object is built without rootDir, forcing the runner consider only the rootDir form the root and not from the project path.
Fixes # (issue)
It was added a verification for the described scenario and an update of each object with the rootDir from the path.
How Has This Been Tested?
It was added two scenarios on the getConfig.test.ts to cover this situation.
Checklist:
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement