fix(plugin-runner-jest): Prepare plugin to deal with projects that ha…

…s more than one projects (#94)
Farfetch · Sep 20, 2022 · c94f1ae · c94f1ae
1 parent 4b772a5
commit c94f1ae
Show file tree

Hide file tree

Showing 4 changed files with 90 additions and 1 deletion.
diff --git a/packages/plugin-runner-jest/__tests__/__snapshots__/getConfig.test.ts.snap b/packages/plugin-runner-jest/__tests__/__snapshots__/getConfig.test.ts.snap
@@ -1,5 +1,47 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
+exports[`Handle multiple projects sharing the same config, when one of the projects contains Jest Projects. 1`] = `
+Object {
+  "collectCoverage": true,
+  "projects": Array [
+    Object {
+      "rootDir": "/test_path",
+      "roots": Array [
+        "<rootDir>/foo",
+      ],
+      "testEnvironment": "jsdom",
+    },
+    Object {
+      "name": "project_1",
+      "rootDir": "/test_path/test",
+    },
+    Object {
+      "name": "project_2",
+      "rootDir": "/test_path/test",
+    },
+  ],
+  "rootDir": "/test_path",
+}
+`;
+
+exports[`Handle project that contains Jest Projects. 1`] = `
+Object {
+  "projects": Array [
+    Object {
+      "name": "project_1",
+    },
+    Object {
+      "name": "project_2",
+    },
+  ],
+  "rootDir": "/test_path/test",
+  "roots": Array [
+    "<rootDir>/",
+  ],
+  "testEnvironment": "node",
+}
+`;
+
 exports[`Handles multiple projects sharing the same config 1`] = `
 Object {
   "collectCoverage": true,

diff --git a/packages/plugin-runner-jest/__tests__/fixtures/basic/test/jest.projects.config.js b/packages/plugin-runner-jest/__tests__/fixtures/basic/test/jest.projects.config.js
@@ -0,0 +1,6 @@
+module.exports = {
+  testEnvironment: 'node',
+  projects: [
+    {name: "project_1"}, {name: "project_2"}
+  ]
+};
diff --git a/packages/plugin-runner-jest/__tests__/getConfig.test.ts b/packages/plugin-runner-jest/__tests__/getConfig.test.ts
@@ -41,3 +41,32 @@ test('Handles multiple projects sharing the same config and one having different
 
   expect(replaceTestPath(jestConfig, cwd)).toMatchSnapshot();
 });
+
+test('Handle multiple projects sharing the same config, when one of the projects contains Jest Projects.', async () => {
+  const cwd = await initFixture('basic');
+  const { context } = await createBatchContext<JestRunnerOptions>(
+    {
+      foo: { configFile: 'jest.config.js' },
+      test: { configFile: '{{projectDir}}/jest.projects.config.js' }
+    },
+    { cwd, schema: require('../src/schema.json') }
+  );
+
+  const jestConfig = await getConfig(context);
+
+  expect(replaceTestPath(jestConfig, cwd)).toMatchSnapshot();
+});
+
+test('Handle project that contains Jest Projects.', async () => {
+  const cwd = await initFixture('basic');
+  const { context } = await createBatchContext<JestRunnerOptions>(
+    {
+      test: { configFile: '{{projectDir}}/jest.projects.config.js' }
+    },
+    { cwd, schema: require('../src/schema.json') }
+  );
+
+  const jestConfig = await getConfig(context);
+
+  expect(replaceTestPath(jestConfig, cwd)).toMatchSnapshot();
+});
diff --git a/packages/plugin-runner-jest/src/index.ts b/packages/plugin-runner-jest/src/index.ts
@@ -148,7 +148,19 @@ export async function getConfig(ctx: Context<JestRunnerOptions>) {
     }
 
     if (isMultipleConfigs && jestConfig.projects) {
-      jestConfig.projects.push(projectConfig as Config.ProjectConfig);
+      if (projectConfig.projects && projectConfig.projects.length > 0) {
+        const newProjects = projectConfig.projects as Config.ProjectConfig[];
+
+        newProjects.forEach(project => {
+          if (projectConfig.rootDir) {
+            project.rootDir = projectConfig.rootDir;
+          }
+        });
+
+        jestConfig.projects.push(...newProjects);
+      } else {
+        jestConfig.projects.push(projectConfig as Config.ProjectConfig);
+      }
     } else {
       Object.assign(jestConfig, projectConfig);
     }