Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the base branch from master to develop and remove feature spec sentence #1712

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Fix the base branch from master to develop and remove feature spec sentence #1712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0409d96
change parent branch from master to develop
MioArai Sep 18, 2024
a142375
remove needless feature spec description
MioArai Sep 18, 2024
aec6b08
remove necessary file
MioArai Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions steps_en.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@ Open chrome://extensions/, enable Developer mode at the top right, and install t
### Step 2: Initialize the Repository

- Create a new branch.
- Create a branch with your account name based on the master branch.
- `git checkout -b github_account_name origin/master`
- Create a branch with your account name based on the develop branch.
- `git checkout -b github_account_name origin/develop`
- After creating the branch, push it.

### Step 3: Create a Rails Project
Expand Down Expand Up @@ -294,7 +294,6 @@ Start with a simple configuration where only the task name and details can be re
1. [Dockerfile](https://qiita.com/ngron/items/f61b8635b4d67f666d75#failed-to-read-the-sessionstorage-property-from-window-storage-is-disabled-inside-data-urls)
2. [spec/rails_helper.rb](https://commis.hatenablog.com/entry/2018/11/16/171608)

- feature specですと `database_cleaner` という gemは必要でしたが、 system specに変更することで `database_cleaner` の導入が要らなくなった
- Introduce CI tools such as CircleCI and set them up to notify Slack.
- If conducting PR exchanges within Fablic/training, introducing CI tools is optional. CircleCI cannot be executed as admin privileges are unavailable, even if .circleci/config.yml is set up.
- Reference book：https://leanpub.com/everydayrailsrspec-jp
Expand Down
7 changes: 3 additions & 4 deletions steps_jp.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ chrome://extensions/ を開いて右上のDeveloper modeをオンにして、RKG
### ステップ2: リポジトリの初期設定をしよう

- ブランチを作成しましょう
- masterブランチを元に自分のアカウント名と同じ名前で作成してください
- `git checkout -b github_account_name origin/master`
- developブランチを元に自分のアカウント名と同じ名前で作成してください
- `git checkout -b github_account_name origin/develop`
- 作成したらpushしましょう

### ステップ3: Railsプロジェクトを作成しよう
Expand Down Expand Up @@ -295,14 +295,13 @@ chrome://extensions/ を開いて右上のDeveloper modeをオンにして、RKG
```
- specを書くための準備をしましょう
- `spec/spec_helper.rb` 、 `spec/rails_helper.rb` を用意しましょう
- ~~feature spec~~ system specをタスク機能に対して書きましょう
- system specをタスク機能に対して書きましょう
- Rails 5.1 以降、新たにsystem testの機能を追加しました
- [日本語](https://qiita.com/jnchito/items/c7e6e7abf83598a6516d), [英語](https://rossta.net/blog/why-rails-system-tests-matter.html)
- dockerを利用して研修を行う場合、以下の設定が必要です。
1. [Dockerfile](https://qiita.com/ngron/items/f61b8635b4d67f666d75#failed-to-read-the-sessionstorage-property-from-window-storage-is-disabled-inside-data-urls)
2. [spec/rails_helper.rb](https://commis.hatenablog.com/entry/2018/11/16/171608)

- feature specですと `database_cleaner` という gemは必要でしたが、 system specに変更することで `database_cleaner` の導入が要らなくなった
- Circle CIなどのCIツールを導入して、Slackに通知するようにしましょう
- Fablic/training内でPRのやり取りをする場合、CIツールの導入は任意(optional)です。CircleCIのAdmin権限が無いので、`.circleci/config.yml`を設定しても実行できないです。
- 参考書籍：https://leanpub.com/everydayrailsrspec-jp
Expand Down