Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the base branch from master to develop and remove feature spec sentence #1712

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

MioArai
Copy link

@MioArai MioArai commented Sep 20, 2024

Background

Ruby on Rails研修を通して不要と思った記述があったのでこちらのPRを作りました

変更点

  • change the base branch from master to develop
  • delete the sentence of the feature spec

Copy link

@mvincent-yap mvincent-yap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fanfannb fanfannb self-requested a review September 20, 2024 02:16
Copy link

@fanfannb fanfannb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MioArai MioArai merged commit 7ab53f7 into develop Sep 20, 2024
2 checks passed
@MioArai MioArai deleted the fix_readme branch September 20, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants