Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgpd: fix update-source for ipv6 #9498

Merged
merged 1 commit into from
Aug 26, 2021
Merged

bgpd: fix update-source for ipv6 #9498

merged 1 commit into from
Aug 26, 2021

Conversation

idryzhov
Copy link
Contributor

There's no IPv6 LL address on loopback/vrf interfaces. So if the user
configures update-source, the session is never going to be established.

Signed-off-by: Igor Ryzhov [email protected]

@idryzhov
bgpd: fix update-source for ipv6
2ebb354 
There's no IPv6 LL address on loopback/vrf interfaces. So if the user
configures update-source, the session is never going to be established.

Signed-off-by: Igor Ryzhov <[email protected]>
polychaeta
polychaeta reviewed Aug 26, 2021
View reviewed changes
Copy link

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to FRR!

Style checking failed; check logs

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

@idryzhov
Copy link
Contributor Author

@mergify backport stable/8.0

@mergify
Copy link

mergify bot commented Aug 26, 2021

Command backport stable/8.0: pending

Waiting for the pull request to get merged

Hey, I reacted but my real name is @Mergifyio

@LabN-CI
Copy link
Collaborator

LabN-CI commented Aug 26, 2021

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/9498 2ebb354
Date 08/26/2021
Start 06:42:33
Finish 07:08:45
Run-Time 26:12
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2021-08-26-06:42:33.txt
Log autoscript-2021-08-26-06:43:39.log.bz2
Memory 515 489 423

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21399/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@donaldsharp donaldsharp merged commit db2ab4d into FRRouting:master Aug 26, 2021
@mergify mergify bot mentioned this pull request Aug 26, 2021
Merged
@mergify
Copy link

mergify bot commented Aug 26, 2021

Command backport stable/8.0: success

Backports have been created

mwinter-osr added a commit that referenced this pull request Aug 26, 2021
@mwinter-osr
Merge pull request #9501 from FRRouting/mergify/bp/stable/8.0/pr-9498
0640479 
bgpd: fix update-source for ipv6 (backport #9498)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polychaeta polychaeta polychaeta left review comments

Assignees
No one assigned
Labels
bgp bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@idryzhov @LabN-CI @NetDEF-CI @polychaeta @donaldsharp