Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the oss-cad-suite package definition to load the official FPGAwars release. #454

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

zapta
Copy link
Collaborator

@zapta zapta commented Nov 12, 2024

After merging this request and updating your pip apio, run this to verify that indeed it's loaded from FPGAwars.

apio packages --install --verbose --force oss-cad-suite

… the official FPGAwars repo (was zapta's test repo).
@cavearr
Copy link
Member

cavearr commented Nov 12, 2024

MErged! @zapta i need you configure your signed capatabilities in git,because i need to be very stricted with this in near future. Very soon i don't permit not signed pull request. This is very important the chatgpt use for a lot of users are generating a very complex situation around licenses and should be necesary implement a DCO very soon ( https://en.wikipedia.org/wiki/Developer_Certificate_of_Origin ) to avoid legal problems in near future.

@cavearr cavearr merged commit d4ca7a9 into FPGAwars:develop Nov 12, 2024
@cavearr
Copy link
Member

cavearr commented Nov 12, 2024

Hi @zapta , make tox are broken , could you review?

@zapta
Copy link
Collaborator Author

zapta commented Nov 12, 2024

@cavearr

  1. I will set the signed capabilities.

  2. The make targets changed. You can see the Makefile for details.

The important ones are:

make lint                // Runs the linters
make test               // runs the tests
make check           // same as 'make lint' and 'make test'
make check_all     // Run 'make check' a few times, with different python versions.

I run 'make check_all' before sending pushing a commit but 'make check' should also be ok if you have only one python version installed.

BTW, the make check_all caught that @override is not available on older python version that apio supports so I took it off.

@cavearr
Copy link
Member

cavearr commented Nov 12, 2024

Thanks! i'm review it and update the actions scripts.

Thanks!! i'm working in Icestudio now integrating your changes.

@zapta
Copy link
Collaborator Author

zapta commented Nov 12, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants