Assorted apio blocking items #453

zapta · 2024-11-12T06:23:00Z

Hi @cavearr, I am nearing the end of the planned feature list and next I will focus on testing and cleanup. Here are a few action items for you that blocks the cleanup.

[DONE] Build oss-cad-tools release 0.2.0 so I can switch the apio dev to it (should not affect apio prod)
Make icestudio using apio.ini so we can make it required and do a bunch of related clean ups.
If icestudio uses apio time please switch to apio report so we can delete apio time.
if icestudio uses apio install or apio uninstall, switch to apio packages so we can delete them.
If icestudio uses apio verify switch to apio lint so we can delete it.

If you have any questions please let me know.

The text was updated successfully, but these errors were encountered:

Obijuan · 2024-11-12T07:17:46Z

Build oss-cad-tools release 0.2.0 so I can switch the apio dev to it (should not affect apio prod)

I've tried to build it but the scripts gives an error:

https://github.com/FPGAwars/tools-oss-cad-suite/actions/runs/11792202730/job/32845461579

When creating the window package it is run out of space: "No space left on device"
Not sure if it is a temporal error or not. I will try to build it later. If the error persist, I will create a release and we can upload the packages manually

@zapta Sorry for no answering all your questions. During this quarter I have to give a lot of lectures at the university and I have no time to spend on Apio. But I will have more free time in a month or so. My stutends use Icestudio 0.12 a lot (with apio 0.9.5). Once the lectures are finished, I will test apio and icestudio for the next release cycle (the new version is the one I will use with the students on the next course)

cavearr · 2024-11-12T08:08:26Z

Hi @zapta , I recommend that your students use the latest wips https://downloads.icestudio.io

This week I started uploading many changes that stabilize and fix UI/UX bugs and in a few days it will integrate your celery changes.

I am going to integrate into icestudio this week the new tools that celery will include by default.

Regarding the actions problem, I am already in the process of solving it, actions have a maximum size, if you cover it you have to go to other options (external workers hosted in your infrastructure and things like that) I am going to try to solve it by deleting temporary files during the build.

Thanks for the great work on Apio.

cavearr · 2024-11-12T08:17:04Z

@zapta , @Obijuan 0.2.0 release are ready!!! 💯

cavearr · 2024-11-12T08:18:20Z

I think today at the end of the day i'm relasing a new wip with your changes.

zapta · 2024-11-12T17:31:30Z

Hi @cavearr, sent you #454 to switch apio dev from my repo to the FPGAwars release you created. After you will update your apio, run that command to update the package and review the repo and version it uses.

zapta · 2024-11-19T18:57:16Z

Regarding item 2, some of the deprecated stuff we can delete there are the flags --size --type --pack, but it's possible that they don't work anyway and therefore can be deleted now.

See #468 for details.

zapta · 2024-11-26T17:30:22Z

Hi @cavearr, any luck with testing the latest apio?

I am ready to make apio.ini required and delete the deprecated commands, once you OK it.

cavearr · 2024-11-26T17:49:58Z

Hi @zapta! i'm on it, i need probably this week to finish the tests and the integration because has been more difficult that i expected at the beginning (icestudio part with all improvements i want to close around this).

I'm telling you when i'll done.

Thanks!

zapta · 2024-12-07T00:39:06Z

Hi @cavearr, what's the status regarding the deprecated commands? Can I go ahead delete them?

Deprecated commands:
  modify     [Depreciated] Modify the apio.ini project file.
  time       [Depreciated] Report design timing.
  verify     [Depreciated] Verify the verilog code.
  install    [Depreciated] Install apio packages.
  uninstall  [Depreciated] Uninstall apio packages.

cavearr · 2024-12-07T07:04:03Z

Hi @zapta i'm working in the migration , i not only change the command line with this change i'm refactoring and migrating icestudio internals to other toolchain architecture, i need few days more. Probably in a couple of days i have it. Thanks! De: "Zapta" ***@***.***> Para: "FPGAwars" ***@***.***> CC: "Carlos" ***@***.***>, "Mention" ***@***.***> Enviados: Sábado, 7 de Diciembre 2024 1:39:29 Asunto: Re: [FPGAwars/apio] Assorted apio blocking items (Issue #453) Hi [ https://github.com/cavearr | @cavearr ] , what's the status regarding the deprecated commands? Can I go ahead delete them? Deprecated commands: modify [Depreciated] Modify the apio.ini project file. time [Depreciated] Report design timing. verify [Depreciated] Verify the verilog code. install [Depreciated] Install apio packages. uninstall [Depreciated] Uninstall apio packages. — Reply to this email directly, [ #453 (comment) | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/ABUVYILTS4AJL4ICP5JRL4D2EI7UDAVCNFSM6AAAAABRTJDXW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRUG4YDKNBTGQ | unsubscribe ] . You are receiving this because you were mentioned. Message ID: ***@***.***>

cavearr · 2024-12-15T23:51:42Z

@zapta i have problems with paths with white space in it (linux and osx, i'll check windows with all works at linux and osx), for example:

"/icestudio/app/resources/collection/examples/1. Basic"
(this is the first example of Icestudio, blink a led) apio execute over:
"/icestudio/app/resources/collection/examples/1. Basic/ice-build/ice-build/01. One LED"

Try to replicate a path with a lot of spaces in diferent folders and try to apply apio commands.

¿Could you check it?

zapta · 2024-12-16T03:07:13Z

Hi @cavearr, this is a known issue. Iverilog -B has a problem with spaces. Do you know if we need the -B flag?

#474

steveicarus/iverilog#1187

I removed spaces from the paths we use for testing to make the tests pass.

[FUNNY_MARKER = "fuññ

cavearr · 2024-12-16T07:26:07Z

Hi @zapta! i'm playing with it, i'm telling you along the day for advances.

I think could be very useful has a "core" apio flag for debugging, for example:

apio --debug lint

and with that flag we can define debug messages for example for print the commands that apio execute, if you don't like the debug flag, what do you think to manage debug messages with an environment variable, for example APIO_DEBUG, at launch apio if detect this environment variable we could print messages , what do you think?

cavearr · 2024-12-16T15:25:09Z

Hi @zapta ! i don't understand well why before this upgrade apio works well with spaces. Is truth that i'm trying the tools directly (iverilog....) and doesn't work with spaces in the path. Very strange but it is.

While this not work in the original tools, we can't support spaces in the path, i'll try to look for this this afternoon , but if i don't fin any solution, i think i put controls in Icestudio to rename paths with spaces and put this feature in standby because this is a blackhole of time.

zapta · 2024-12-16T16:53:37Z

Hi @cavearr, I think it's a good idea to have a check in IceStudio until we resolve this issue.

Apio also has a similar check.

apio/apio/apio_context.py

Line 105 in f5c5df3

ApioContext._check_no_spaces_in_dir(self.project_dir, "project")

cavearr · 2024-12-16T16:56:24Z

yes! just now i'm playing with it, i think i'm near a solution but for now not works yet.

zapta · 2024-12-16T16:56:54Z

Hi @cavearr, the debug flag or var is a good idea and I can implement it, but I prefer to do that after I clean apio.

Any news on items 2-5? Can I delete the deprecated commands (already have a pending change) and make apio.ini required?

zapta · 2024-12-16T17:00:50Z

@cavearr, for testing your whitespace solution try to run the apio tests make check after you make these changes

Add a space before and after the 'funny' here

apio/test/conftest.py

Line 34 in f5c5df3

FUNNY_MARKER = "fuññy"
Comment out the code of this function

apio/apio/apio_context.py

Line 224 in f5c5df3

if re.search("\\s", str(dir_path)):

cavearr · 2024-12-16T17:07:05Z

@zapta, If only affect to apio develop go ahead! i'm working in icestudio wips and some things not work now for the latest changes in apio, for this go ahead and i still working in stabilize the wip as soon as possible.

Thanks for the tip!

zapta · 2024-12-16T17:39:54Z

Thanks @cavearr. Yes, it's in the develope branch. I will got ahead and send the changes, deleting the 5 deprecated commands and making apio.ini required and only source of project configuration.

cavearr · 2024-12-16T18:53:49Z

2. apio/apio_context.py

Hi @zapta doing this , all appears works well? a could try in other way, but i want to use it if you make this test to check the whitespates, but the output is all ok:

python -m tox --skip-missing-interpreters false -e py312 -- --offline
.pkg: _optional_hooks> python /Users/carl/opt/miniconda3/envs/icestudio/lib/python3.13/site-packages/pyproject_api/_backend.py True flit_core.buildapi
.pkg: get_requires_for_build_sdist> python /Users/carl/opt/miniconda3/envs/icestudio/lib/python3.13/site-packages/pyproject_api/_backend.py True flit_core.buildapi
.pkg: get_requires_for_build_wheel> python /Users/carl/opt/miniconda3/envs/icestudio/lib/python3.13/site-packages/pyproject_api/_backend.py True flit_core.buildapi
.pkg: prepare_metadata_for_build_wheel> python /Users/carl/opt/miniconda3/envs/icestudio/lib/python3.13/site-packages/pyproject_api/_backend.py True flit_core.buildapi
.pkg: build_sdist> python /Users/carl/opt/miniconda3/envs/icestudio/lib/python3.13/site-packages/pyproject_api/_backend.py True flit_core.buildapi
py312: install_package> python -I -m pip install --force-reinstall --no-deps /Users/carl/work/apio/.tox/.tmp/package/8/apio-0.9.6.tar.gz
py312: commands[0]> python -m pytest --cov --cov-report=html apio test --offline
================================================================================================================ test session starts ================================================================================================================
platform darwin -- Python 3.12.8, pytest-8.3.3, pluggy-1.5.0
cachedir: .tox/py312/.pytest_cache
rootdir: /Users/carl/work/apio
configfile: pyproject.toml
plugins: cov-5.0.0
collected 60 items

test/commands/test_boards.py .. test/commands/test_build.py ... test/commands/test_clean.py ... test/commands/test_create.py . test/commands/test_drivers.py . test/commands/test_examples.py . test/commands/test_fpgas.py .. test/commands/test_graph.py .. test/commands/test_install.py . test/commands/test_lint.py . test/commands/test_modify.py . test/commands/test_packages.py . test/commands/test_report.py .. test/commands/test_sim.py . test/commands/test_system.py . test/commands/test_test.py . test/commands/test_time.py .. test/commands/test_uninstall.py . test/commands/test_upgrade.py s test/commands/test_upload.py ... test/commands/test_verify.py . test/integration/test_examples.py s test/integration/test_packages.py s test/integration/test_projects.py ss test/integration/test_utilities.py s test/managers/test_scons_args.py . test/managers/test_scons_filters.py . test/scons/test_scons_util.py test/test_apio.py .. test/test_apio_context.py . test/test_cmd_util.py . test/test_util.py .. [ 3%]
[ 8%]
[ 13%]
[ 15%]
[ 16%]
[ 18%]
[ 21%]
[ 25%]
[ 26%]
[ 28%]
[ 30%]
[ 31%]
[ 35%]
[ 36%]
[ 38%]
[ 40%]
[ 43%]
[ 45%]
[ 46%]
[ 51%]
[ 53%]
[ 55%]
[ 56%]
[ 60%]
[ 61%]
[ 63%]
[ 65%]
............... [ 90%]
[ 93%]
[ 95%]
[ 96%]
[100%]

---------- coverage: platform darwin, python 3.12.8-final-0 ----------
Coverage HTML written to dir htmlcov

=========================================================================================================== 54 passed, 6 skipped in 2.03s ===========================================================================================================
.pkg: _exit> python /Users/carl/opt/miniconda3/envs/icestudio/lib/python3.13/site-packages/pyproject_api/_backend.py True flit_core.buildapi
py312: OK (6.01=setup[3.76]+cmd[2.24] seconds)
congratulations :) (6.04 seconds)

cavearr · 2024-12-16T20:10:44Z

@zapta i'm testing apio from console outside icestudio and all works well with white spaces in paths, in fact i need remove the check of spaces in the apio path because this is important to support , there are a lot of examples and people use directorios with spaces, i prefer that you remove this check from apio.

The think that fails is when apio dir is inside a path with spaces, this only affect for development or for users with usernames with spaces, i think this check could be fine (check if apio_home has spaces, but not the project dir that works well). We could maitain open the issue for APIO_HOME with spaces while verilator support it, but this is not important if we advice to the user.

What do you think? could do you do it?

zapta · 2024-12-16T20:59:24Z

@cavearr, the --offline causes the real tests to be skipped (notice the 's' marks in the integration tests). Try to run make check which is the standard way we check before submitting.

I can remove the two checks and leave only for the apio home path. Will also modify the test such that those two paths have contains white spaces.

cavearr · 2024-12-16T21:39:53Z

Thanks @zapta, running "make check" and review errors!

Testing boards with apio commands all works well with spaces in the path (with apio installed in APIO_HOME without spaces) as i said before, is very important that this could work as now, and appears works well.

cavearr · 2024-12-17T18:09:15Z

@zapta i need unblock the constraint of apio when detect spaces in paths, if you couldn't today i could do it without problems, only tell me ok?

zapta · 2024-12-17T18:41:58Z

Hi @cavearr, please do.

cavearr · 2024-12-17T18:45:43Z

Thanks, this is in my side!

zapta · 2024-12-17T20:21:24Z

I presume that this is an apio commit. Can you submit it now so I can merge it with my changes?

…

On Tue, Dec 17, 2024 at 10:46 AM Carlos Venegas Arrabé < ***@***.***> wrote: Thanks, this is in my side! — Reply to this email directly, view it on GitHub <#453 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQVMQOQWCCWAJGB3CK3YQ32GBWO5AVCNFSM6AAAAABRTJDXW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBZGMYTQOJXGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

cavearr · 2024-12-17T20:38:00Z

Hi @zapta i have fix the problem with spaces in path (for tests).

Check test_examples.py file, at Apio we should adapt the path management like the example i fix it. The only way in that all paths works is with pathlib library, please check the file to view it.

In other way i think we need to change the path creation from something like:

base_path / "examples" / "Alhambra-II" / "ledon" / "ledon.v"

to solution with os.path.join or similar because we need to do multi platform paths (Windows).

zapta · 2024-12-18T06:16:22Z

Hi @cavearr, I believe that that the / is a redefinition of the div operator for the Path class, that accepts a string as an argument and return a new joined Path. That is, it's not a simple concatenation using the "/" string, but an abstracted path joining using an operator that was designed for it.

https://stackoverflow.com/questions/53083963/python-pathlib-operator-how-does-it-do-it

If you have an example that doesn't behave well please let me know.

zapta · 2024-12-22T23:10:24Z

All items got unblocked. Thanks.

Closing.

This was referenced Nov 19, 2024

How to use the flags --size, --type, --pack? #468

Closed

apio clean now deletes also old build files that are not in the _build directory. #471

Merged

This was referenced Dec 12, 2024

[Feature Request] Support multiple build env variations. #493

Open

Delete the old apio documentation #498

Open

zapta closed this as completed Dec 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Assorted apio blocking items #453

Assorted apio blocking items #453

zapta commented Nov 12, 2024 •

edited

Loading

Obijuan commented Nov 12, 2024

cavearr commented Nov 12, 2024

cavearr commented Nov 12, 2024

cavearr commented Nov 12, 2024

zapta commented Nov 12, 2024

zapta commented Nov 19, 2024 •

edited

Loading

zapta commented Nov 26, 2024

cavearr commented Nov 26, 2024

zapta commented Dec 7, 2024

cavearr commented Dec 7, 2024 via email

cavearr commented Dec 15, 2024

zapta commented Dec 16, 2024

cavearr commented Dec 16, 2024

cavearr commented Dec 16, 2024

zapta commented Dec 16, 2024

cavearr commented Dec 16, 2024

zapta commented Dec 16, 2024

zapta commented Dec 16, 2024

cavearr commented Dec 16, 2024 •

edited

Loading

zapta commented Dec 16, 2024

cavearr commented Dec 16, 2024

cavearr commented Dec 16, 2024

zapta commented Dec 16, 2024

cavearr commented Dec 16, 2024

cavearr commented Dec 17, 2024

zapta commented Dec 17, 2024

cavearr commented Dec 17, 2024

zapta commented Dec 17, 2024 via email

cavearr commented Dec 17, 2024

zapta commented Dec 18, 2024

zapta commented Dec 22, 2024

Assorted apio blocking items #453

Assorted apio blocking items #453

Comments

zapta commented Nov 12, 2024 • edited Loading

Obijuan commented Nov 12, 2024

cavearr commented Nov 12, 2024

cavearr commented Nov 12, 2024

cavearr commented Nov 12, 2024

zapta commented Nov 12, 2024

zapta commented Nov 19, 2024 • edited Loading

zapta commented Nov 26, 2024

cavearr commented Nov 26, 2024

zapta commented Dec 7, 2024

cavearr commented Dec 7, 2024 via email

cavearr commented Dec 15, 2024

zapta commented Dec 16, 2024

cavearr commented Dec 16, 2024

cavearr commented Dec 16, 2024

zapta commented Dec 16, 2024

cavearr commented Dec 16, 2024

zapta commented Dec 16, 2024

zapta commented Dec 16, 2024

cavearr commented Dec 16, 2024 • edited Loading

zapta commented Dec 16, 2024

cavearr commented Dec 16, 2024

cavearr commented Dec 16, 2024

zapta commented Dec 16, 2024

cavearr commented Dec 16, 2024

cavearr commented Dec 17, 2024

zapta commented Dec 17, 2024

cavearr commented Dec 17, 2024

zapta commented Dec 17, 2024 via email

cavearr commented Dec 17, 2024

zapta commented Dec 18, 2024

zapta commented Dec 22, 2024

zapta commented Nov 12, 2024 •

edited

Loading

zapta commented Nov 19, 2024 •

edited

Loading

cavearr commented Dec 16, 2024 •

edited

Loading