Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUSHI Config Groups doesn't handle groups without resources #1019

Closed
cmoesel opened this issue Feb 10, 2022 · 0 comments · Fixed by #1091
Closed

SUSHI Config Groups doesn't handle groups without resources #1019

cmoesel opened this issue Feb 10, 2022 · 0 comments · Fixed by #1091
Labels
bug Something isn't working

Comments

@cmoesel
Copy link
Member

cmoesel commented Feb 10, 2022

SUSHI allows groups to be defined in sush-config.yaml without resource, like this:

groups:
  Group A: My Group A
  Group B: My Group B

or with resources, like this:

groups:
  GroupA:
    name: Group A
    description: My Group A
    resources:
    - StructureDefinition/ProfileA1
    - StructureDefinition/ProfileA2
  GroupB:
    name: Group B
    description: My Group B
    resources:
    - StructureDefinition/ProfileB1
    - StructureDefinition/ProfileBA2

If you use the latter format, but don't provide resources, SUSHI issues an error. E.g.:

groups:
  GroupA:
    name: Group A
    description: My Group A
  GroupB:
    name: Group B
    description: My Group B

results in:

error SUSHI encountered the following unexpected error: group.resources is not iterable

Ideally, SUSHI should be able to handle this and just process the group name and description without any resources.

@cmoesel cmoesel added bug Something isn't working added to backlog labels Feb 10, 2022
cmoesel added a commit that referenced this issue May 18, 2022
julianxcarter pushed a commit that referenced this issue May 24, 2022
* Support for using resource names/ids in sushi-config.yaml

Allow authors to use resource names or ids for:
- global profile values (previous required canonical)
- group resources (previously required relative URL)
- resources (previously required relative URL)
- resources exampleCanonicals (previously required canonical)

Fixes #1018

* Support config groups with no resources

Fixes #1019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant