Support config groups with no resources

Fixes #1019
FHIR · May 18, 2022 · 1516148 · 1516148
1 parent 6bb534a
commit 1516148
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 18 deletions.
diff --git a/src/fshtypes/Configuration.ts b/src/fshtypes/Configuration.ts
@@ -145,7 +145,7 @@ export type ConfigurationGroup = {
   id: string;
   name: string;
   description?: string;
-  resources: string[];
+  resources?: string[];
 };
 
 export type ConfigurationResource = ImplementationGuideDefinitionResource & { omit?: boolean };

diff --git a/src/ig/IGExporter.ts b/src/ig/IGExporter.ts
@@ -1069,25 +1069,27 @@ export class IGExporter {
   private addConfiguredGroups(): void {
     for (const group of this.config.groups ?? []) {
       this.addGroup(group.id, group.name, group.description);
-      for (const resourceKey of group.resources) {
-        const existingResource = this.ig.definition.resource.find(
-          resource => resource.reference?.reference === resourceKey
-        );
-        if (!existingResource) {
-          logger.error(`Group ${group.id} configured with nonexistent resource ${resourceKey}`);
-        } else {
-          if (existingResource.groupingId) {
-            if (existingResource.groupingId === group.id) {
-              logger.warn(
-                `Resource ${resourceKey} is listed as a member of group ${group.id}, and does not need a groupingId.`
-              );
-            } else {
-              logger.error(
-                `Resource ${resourceKey} configured with groupingId ${existingResource.groupingId}, but listed as member of group ${group.id}.`
-              );
+      if (group.resources) {
+        for (const resourceKey of group.resources) {
+          const existingResource = this.ig.definition.resource.find(
+            resource => resource.reference?.reference === resourceKey
+          );
+          if (!existingResource) {
+            logger.error(`Group ${group.id} configured with nonexistent resource ${resourceKey}`);
+          } else {
+            if (existingResource.groupingId) {
+              if (existingResource.groupingId === group.id) {
+                logger.warn(
+                  `Resource ${resourceKey} is listed as a member of group ${group.id}, and does not need a groupingId.`
+                );
+              } else {
+                logger.error(
+                  `Resource ${resourceKey} configured with groupingId ${existingResource.groupingId}, but listed as member of group ${group.id}.`
+                );
+              }
             }
+            existingResource.groupingId = group.id;
           }
-          existingResource.groupingId = group.id;
         }
       }
     }

diff --git a/test/ig/IGExporter.IG.test.ts b/test/ig/IGExporter.IG.test.ts
@@ -600,6 +600,11 @@ describe('IGExporter', () => {
           name: 'My Observation Group',
           description: 'Group for some observation-related things.',
           resources: ['StructureDefinition/sample-observation']
+        },
+        {
+          id: 'MyEmptyGroup',
+          name: 'My Empty Group',
+          description: 'A group for when nothing is better than something.'
         }
       ];
       exporter.export(tempOut);
@@ -621,6 +626,11 @@ describe('IGExporter', () => {
         name: 'My Observation Group',
         description: 'Group for some observation-related things.'
       });
+      expect(content.definition.grouping).toContainEqual({
+        id: 'MyEmptyGroup',
+        name: 'My Empty Group',
+        description: 'A group for when nothing is better than something.'
+      });
       const samplePatient: ImplementationGuideDefinitionResource = content.definition.resource.find(
         (r: ImplementationGuideDefinitionResource) =>
           r?.reference?.reference === 'StructureDefinition/sample-patient'