Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Divisions to scoreboard #4263

Merged
merged 7 commits into from
Jan 28, 2023
Merged

Conversation

4z0t
Copy link
Member

@4z0t 4z0t commented Oct 12, 2022

Related to this #4258, however can't test it since everybody must have this code on their side in order to see division of every player (by default all gm's lmao) and position must be corrected for sure. (Works in autolobby only) Decided to not change base scoreboard layout leaving it for modders.

@4z0t
Copy link
Member Author

4z0t commented Dec 1, 2022

@Garanas I can leave only the fact of divisions, because this PR waits for too long

@4z0t
Copy link
Member Author

4z0t commented Jan 24, 2023

@Garanas what are we doing with this one?

@4z0t
Copy link
Member Author

4z0t commented Jan 24, 2023

It also requires other division textures.

@4z0t 4z0t requested review from Garanas and Hdt80bro January 27, 2023 13:19
@Hdt80bro
Copy link
Contributor

Is this supposed to add divisions to the scoreboard or lobby? I see code that sets up both, but not actually doing either.

@4z0t
Copy link
Member Author

4z0t commented Jan 27, 2023

@Hdt80bro it adds only the fact that player has division. Those are provided through gameoptions.

@BlackYps
Copy link
Contributor

It's supposed to be for the scoreboard. Maybe we can show them in the lobby as well at a later point, but for now the focus is the scoreboard

@4z0t
Copy link
Member Author

4z0t commented Jan 27, 2023

I don't see a better place for divisions in base scoreboard.

@BlackYps
Copy link
Contributor

It's supposed to replace rating

@4z0t
Copy link
Member Author

4z0t commented Jan 27, 2023

In base scoreboard rating is concatenated with nickname. What i mean is current code base isn't suitable for any changes like this. I will add in my scoreboard for sure 🙂

@Garanas Garanas merged commit b067d18 into FAForever:deploy/fafdevelop Jan 28, 2023
@Garanas Garanas added the area: ui Anything to do with the User Interface of the Game label Feb 23, 2023
@Garanas Garanas added this to the Development iteration I milestone Feb 23, 2023
@BlackYps BlackYps mentioned this pull request May 8, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ui Anything to do with the User Interface of the Game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants