-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Divisions to scoreboard #4263
Conversation
@Garanas I can leave only the fact of divisions, because this PR waits for too long |
@Garanas what are we doing with this one? |
It also requires other division textures. |
Is this supposed to add divisions to the scoreboard or lobby? I see code that sets up both, but not actually doing either. |
@Hdt80bro it adds only the fact that player has division. Those are provided through gameoptions. |
It's supposed to be for the scoreboard. Maybe we can show them in the lobby as well at a later point, but for now the focus is the scoreboard |
I don't see a better place for divisions in base scoreboard. |
It's supposed to replace rating |
In base scoreboard rating is concatenated with nickname. What i mean is current code base isn't suitable for any changes like this. I will add in my scoreboard for sure 🙂 |
d0a77bd
to
4c8aca6
Compare
Related to this #4258, however can't test it since everybody must have this code on their side in order to see division of every player
(by default all gm's lmao) and position must be corrected for sure.(Works in autolobby only) Decided to not change base scoreboard layout leaving it for modders.