Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump expensify-common to latest version #521

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Conversation

NJ-2020
Copy link
Contributor

@NJ-2020 NJ-2020 commented Oct 18, 2024

Details

In this PR we decided to match a room name if they are preceded by newline/space.

Related Issues

Expensify/App#46299

Manual Tests

  1. Go to Expensify App
  2. Tap on a room chat
  3. Go to composer
  4. Mention any room starting with symbol before #
  5. Verify that the room name will be normal text

Linked PR

@NJ-2020
Copy link
Contributor Author

NJ-2020 commented Oct 18, 2024

PR ready

cc: @rojiphil

@tomekzaw
Copy link
Collaborator

Thanks for the PR! I had to regenerate react-native-live-markdown-parser.js because CI check was failing.

@tomekzaw tomekzaw merged commit 7886b8c into Expensify:main Oct 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants