[HOLD for payment 2024-11-11] [$250] Android - Room - Whisper displays 1 mention when 2 mentions are send in specific way

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.12
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4768836
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch app
2. Tap on a room chat
3. Enter [HOLD for payment 2021-09-10] Sign in - Error message is not specific if password is not entered #4856₹&_#7553 and sent the message
4. Note whisper for 2 mentions are shown
5. Enter #gh4h_+&&&-#ehhh & send the message
6. Note whisper for only one mention is shown

Expected Result:

Whisper must display 2 mention when 2 mentions are send

Actual Result:

Whisper displays 1 mention when 2 mentions are send in specific way.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6552678_1721913220722.Screenrecorder-2024-07-25-18-36-09-985_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01903b4afb9ff494db
• Upwork Job ID: 1827453197366571253
• Last Price Increase: 2024-09-21
• Automatic offers:
• rojiphil | Reviewer | 104095172
• NJ-2020 | Contributor | 104095173

Issue Owner

Current Issue Owner: @OfstadC

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

We think that this bug might be related to #vip-vsp

[lanitochka17]

@kevinksullivan FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

@kevinksullivan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@kevinksullivan Eep! 4 days overdue now. Issues have feelings too...

[kevinksullivan]

@lanitochka17 does this happen with other combinations of room references? I'm sort of confused because both strings are just one line with no spaces, so I am not sure what is supposed to happen here.

[melvin-bot]

@kevinksullivan, @lanitochka17 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@kevinksullivan, @lanitochka17 Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@kevinksullivan @lanitochka17 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@kevinksullivan, @lanitochka17 Still overdue 6 days?! Let's take care of this!

[kevinksullivan]

Bump @lanitochka17

[lanitochka17]

@kevinksullivan According steps in TR https://expensify.testrail.io/index.php?/tests/view/4768836 step 5 is fail when create whisper with new room.
Expected resault: Verify an actionable whisper asking the user if they want to create the room is triggered.

[lanitochka17]

Issue is still reproducible

az_recorder_20240812_183917_compress_1.mp4

[Beamanator]

Oh wow thanks @rojiphil - removing Needs Reproduction 👍

[melvin-bot]

@rojiphil, @Beamanator, @OfstadC, @NJ-2020 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[rojiphil]

@NJ-2020 Does this sound like the next steps?

[NJ-2020]

@rojiphil Yes

For react-native-live-markdown here's the PR
For the main repo App i will create the PR as soon as possible when the above one get merged

[NJ-2020]

PR ready for review

cc: @rojiphil

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.56-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Bump expensify-common to 2.0.101 #51073

If no regressions arise, payment will be issued on 2024-11-11. 🎊

For reference, here are some details about the assignees on this issue:

• @rojiphil requires payment automatic offer (Reviewer)
• @NJ-2020 requires payment automatic offer (Contributor)

[melvin-bot]

@rojiphil @OfstadC The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[OfstadC]

@rojiphil please finish BZ checklist so I can issue payment on 11/11 😄

[rojiphil]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: Not Required. The existing checklist is good enough to capture such issues.

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal

Precondition:

Test:

1. Navigate to any chat e.g. a workspace chat.
2. Enter the message #4856₹&_#7553 in composer and verify that only #4856 is highlighted.
3. Send the message and verify that the Concierge message mentions only #4856 for room creation.
4. Repeat Steps (2) and (3) and verify the expected result:
   a. Message: #gh4h_+&&&-#ehhh, Expected Result: Only #gh4h
   b. Message: #4856₹& #7553, Expected Result: #4856 and #7553
   c. Message: #4856₹&
#7553, Expected Result: #4856 and #7553
   d. Message: #4856₹&*#7553, Expected Result: Only #4856
   e. Message: #4856₹&~#7553, Expected Result: Only #4856
   f. Message: #4856₹& *#7553, Expected Result: #4856 and #7553
   g. Message: #4856₹& ~#7553, Expected Result: #4856 and #7553
   h. Message: #4856₹&
*#7553, Expected Result: #4856 and #7553
   i. Message: #4856₹&
~#7553, Expected Result: #4856 and #7553
   j. Message: #4856₹&
_#7553, Expected Result: #4856 and #7553
   k. Message: #4856₹&
-#7553, Expected Result: Only #4856
   l. Message: #room-name123, Expected Result: #room-name123
   m. Message: https://abc.com/abc#qwer, Expected Result: Nothing is highlighted

Do we agree 👍 or 👎

[rojiphil]

please finish BZ checklist so I can issue payment on 11/11

@OfstadC I have completed the BZ checklist. Also, it looks like a new offer needs to be created for me as the old one expired. Thanks.

[OfstadC]

https://github.com/Expensify/Expensify/issues/443327

[OfstadC]

Payment Summary

• @rojiphil paid $250 via Upwork
• @NJ-2020 paid $250 via Upwork