Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove text selection hack for Android as FlatList fixes everything! #578

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

AndrewGable
Copy link
Contributor

@marcaaron - Will you please review?

Removes a hack on Android for text selection, now that FlatList is implemented text selection and scroll speed seems performant.

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/141699

Tests

  1. Build for iOS and Android
  2. Verify scroll speed is fast
  3. Verify you can select text

Screenshots

N/A

@AndrewGable AndrewGable requested a review from marcaaron October 1, 2020 18:26
@AndrewGable AndrewGable requested a review from tgolen as a code owner October 1, 2020 18:26
@AndrewGable AndrewGable self-assigned this Oct 1, 2020
Copy link
Contributor

@tgolen tgolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@marcaaron
Copy link
Contributor

Gonna give this a test now! spent a bit of time figuring out why logging in was broken and couldn't test this.

Copy link
Contributor

@marcaaron marcaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marcaaron
Copy link
Contributor

Tested on Android and was able to select text and scrolling was as fast as it was before.

Only thing I noticed is that we can only select one comment at a time. Selecting several comments does not work, but I don't think it's something we need to block on.

@marcaaron marcaaron merged commit 784e8a8 into master Oct 5, 2020
@marcaaron marcaaron deleted the andrew-android-select branch October 5, 2020 21:29
@Julesssss
Copy link
Contributor

Julesssss commented Oct 6, 2020

Tested on Android and was able to select text and scrolling was as fast as it was before.

Only thing I noticed is that we can only select one comment at a time. Selecting several comments does not work, but I don't think it's something we need to block on.

I believe this is an Android TextView limitation, as it is only possible to copy from one TextView component at a time. Most messaging apps use a long press context menu to copy text, but this is still limited to a single message.

@marcaaron marcaaron mentioned this pull request Mar 29, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants