Fix missing avatars #2099
Fix missing avatars #2099
Conversation
|
|
||
| // Setting removeClippedSubviews will break text selection on Android | ||
| // eslint-disable-next-line react/jsx-props-no-multi-spaces | ||
| removeClippedSubviews={false} |
There was a problem hiding this comment.
@AndrewGable do you remember how this broke text selection on Android? I tested it and seemed to work ok to me, but maybe I misinterpreted this comment.
There was a problem hiding this comment.
I believe it was something along the lines of https://stackoverflow.com/a/66703331/2509962
There was a problem hiding this comment.
Chatted with Andrew and neither one of us could remember why it was added. We're also going to implement a long press menu to select the entire contents of a message IIRC so whatever this refers to (still not entirely sure) might be even less relevant in the future.
| @@ -0,0 +1,3 @@ | |||
| import {SectionList} from 'react-native'; | |||
|
|
|||
| export default SectionList; | |||
There was a problem hiding this comment.
Not much 😄 . It imports the unmodified SectionList and then re-exports it. This is because we have different builds depending on the platform and will switch extensions e.g.
import SectionList from './SectionList';On web, this will pull from /SectionList/index.js but on Android it will use /SectionList/index.android.js
So we are basically saying, when building for web use the unmodified SectionList
There was a problem hiding this comment.
This tests well for me, my only question before merging is the same as #2099 (comment) to confirm there isn't a regression we're unaware of. To clarify, I don't see any text selection regressions while testing, but I want to confirm I'm not missing anything.
|
Gonna proceed with merging this one since:
|
Details
Fixed Issues
https://github.com/Expensify/Expensify/issues/154715
Tests
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android