Revert regex changes for 
comment
#4917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flodnv
reviewed
Aug 30, 2021
| @@ -96,7 +96,6 @@ describe('checkDeployBlockers', () => { | |||
| mockGetIssue.mockResolvedValue(checkedBoxesNoShipitIssue); | |||
| // eslint-disable-next-line max-len | |||
| baseComments.data.push({body: 'This issue either has unchecked QA steps or has not yet been stamped with a :shipit: comment. Reopening!'}); | |||
| baseComments.data.push({body: 'This is another comment!'}); | |||
There was a problem hiding this comment.
I don't think I understand why this was removed?
There was a problem hiding this comment.
This line was added to update the test to work with the previous change, we want to revert the change and therefore revert the test too.
There was a problem hiding this comment.
We want to basically revert half of: #4824 since it had two changes:
- Regex for (and the updated tests)
- 404 issue with the wrong link
This is just reverting 1.
flodnv
approved these changes
Aug 30, 2021
roryabraham
approved these changes
Aug 30, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @roryabraham in version: 1.0.89-0 🚀
|
4 tasks
|
🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Reverts two lines of a PR that is causing issues with the deploy:
Tests