Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix owner to fix 404 when trying to comment #4824

Merged
merged 6 commits into from
Aug 26, 2021
Merged

Conversation

AndrewGable
Copy link
Contributor

@AndrewGable AndrewGable commented Aug 25, 2021

Details

Fixes broken commenting on staging qa checklists like this: https://github.com/Expensify/App/runs/3424743113?check_suite_focus=true#step:3:44

Fixed Issues

N/A

Tests

  1. Close a QA checklist with an item unchecked, verify it comments on the issue correctly

@AndrewGable AndrewGable self-assigned this Aug 25, 2021
@AndrewGable AndrewGable marked this pull request as ready for review August 25, 2021 17:33
@AndrewGable AndrewGable requested a review from a team as a code owner August 25, 2021 17:33
@MelvinBot MelvinBot requested review from bondydaa and removed request for a team August 25, 2021 17:34
bondydaa
bondydaa previously approved these changes Aug 25, 2021
Copy link
Contributor

@bondydaa bondydaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 restarted all jobs since one failed and it looked to be a npm issue

@AndrewGable
Copy link
Contributor Author

I think the jest tests are failing for real, I will look into it

@AndrewGable
Copy link
Contributor Author

Tests should be passing, ready for review!

@AndrewGable AndrewGable requested a review from bondydaa August 25, 2021 22:07
@roryabraham roryabraham merged commit 5e51ce7 into main Aug 26, 2021
@roryabraham roryabraham deleted the andrew-fix-comment branch August 26, 2021 02:16
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @roryabraham in version: 1.0.87-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants