Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed alignment issue for Workspace name #4901

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

akshayasalvi
Copy link
Contributor

@akshayasalvi akshayasalvi commented Aug 29, 2021

@Julesssss Can you please review and merge this?

Details

Fixed Issues

$ #4860
$ #4835

Tests

  1. Tested long name and shortname of workspace for alignment

QA Steps

  1. Check alignment of the workspace title on Workspace Sidebar.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screenshot 2021-08-29 at 9 28 23 PM

Mobile Web

Screenshot 2021-08-29 at 9 40 54 PM

Desktop

Screenshot 2021-08-29 at 9 34 53 PM

iOS

Screenshot 2021-08-29 at 10 41 17 PM

Android

Screenshot 2021-08-29 at 10 01 19 PM

@akshayasalvi akshayasalvi requested a review from a team as a code owner August 29, 2021 16:32
@MelvinBot MelvinBot requested review from nkuoch and removed request for a team August 29, 2021 16:32
@nkuoch nkuoch merged commit dafdef0 into Expensify:main Aug 30, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @nkuoch in version: 1.0.88-3 🚀

platform result
🤖 android 🤖 cancelled 🔪
🖥 desktop 🖥 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Sep 1, 2021

🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants