[Pay 9/6] Long Workspace Name gets Cut

[akshayasalvi]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Enter a very long email address for the signin
2. Go to FAB and click on New Workspace
3. You'll see that the workspace name has no margin and it gets cut from the screen.

Expected Result:

Should have a margin with the text having ellipses. It should then on hover show the full name.

Actual Result:

Text gets cut and no way to see the full workspace name.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @mateocole (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[akshayasalvi]

Proposed Solution

In WorkspaceSidebar change the policy.name Pressable as:

<Pressable
    style={[
        styles.alignSelfCenter,
        styles.mt4,
        styles.mb6,
        styles.w100,
    ]}
    onPress={openEditor}
>
    <Tooltip text={policy.name}>
        <Text
            numberOfLines={1}
            style={[
                styles.displayName,
            ]}
        >
            {policy.name}
        </Text>
    </Tooltip>
</Pressable>

After applying the above fix this is how it'll look:

[MelvinBot]

@mateocole Eep! 4 days overdue now. Issues have feelings too...

[MelvinBot]

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mountiny]

This can be worked on by external contributor for sure, assigning the label.

[MelvinBot]

Triggered auto assignment to @mallenexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[MelvinBot]

Triggered auto assignment to @Julesssss (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mallenexpensify]

Job posted to Upwork https://www.upwork.com/jobs/~01907c7fb70ee8f131
@Julesssss can you review @akshayasalvi 's proposal above? #4747 (comment)

[Julesssss]

Looks good to me. Please go ahead and hire @akshayasalvi

[mallenexpensify]

Hired @akshayasalvi in Upwork!

[akshayasalvi]

@Julesssss PR Raised. I found the same issue in the sidebar as well. I've fixed that as well.

[Julesssss]

Hi @akshayasalvi I see the ellipsis in the sidebar, but not the tooltip. My guess is that this isn't possible as it's a different Component type, is that the case?

[akshayasalvi]

@Julesssss I didn't add Tooltip there because it was more like a MenuItem component. We are reusing the same component for the other menus like Preferences, etc. Also, I feel the Tooltip there will look a little weird. Let me know your thoughts.

[Julesssss]

It's not a huge problem and I think we would still want to ellipsis, but it would be better to have the ToolTip show in both places.

[akshayasalvi]

Let me see what I can do. Will send an update by tomorrow. Will that be okay?

[Julesssss]

If we don't show the Tooltip in any other menu option then I think we can merge as is, just taking a look.

[akshayasalvi]

IIRC, we don't at the moment. I had checked it earlier.

[Julesssss]

Yep, I don't see it either. We may introduce further issues by modifying the menu Component, so let's merge as is 👍

[akshayasalvi]

Okay. Thank you for the confirmation.

[Julesssss]

I didn't even notice that this had been merged already 😄

FYI @aldo-expensify we should await the contributor manager engineer review so that the next steps in the process aren't missed.

[aldo-expensify]

I didn't even notice that this had been merged already 😄

FYI @aldo-expensify we should await the contributor manager engineer review so that the next steps in the process aren't missed.

Sorry about that @Julesssss ! next time I'll just review, approve and comment :)

[Julesssss]

For reference, it looks like this regression was introduced by this issue, and has been fixed already.

[mallenexpensify]

Updating payment til 9/6, due to regression.

[mallenexpensify]

Paid in Upwork, included bonus for reporting the issue