[#Wave-Control: Add NetSuite]: Settings Configuration in NewDot: Import Mapping #44743

mananjadhav · 2024-07-02T18:51:55Z

Details

Covers the implementation of Import mappings page - Departments, Classes, Locations, Customers, Projects.

This is one of the FE PRs for NetSuite without the proper auth flow integrated. Hence, to get this working we'll need to have a few pre-requisites:

Collect workspace with accounting enabled.
NetSuite beta enabled for the user. You can return true in the canUseNetSuiteIntegration method.
Setup the Netsuite data. You can either connect the account using OldDot or populate the data linked in the comment here for the given workspace as connections: {netsuite: <linkedjson>}.

One way I did the setup is calling Onyx.merge with useEffect on any FE component.
   useEffect(() => {
       Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}76A10AB364F95DA0`, {"connections":{"netsuite":{"accountID":"TSTDRV1668486", ....})
   }, []);

Details

Fixed Issues

$ #43437
PROPOSAL:

Tests

Open the app with the pre-setup workspace.
Go to Accounting from the LHS
Verify that you're able to see Net Suite in the active connections along with the Oracle NetSuite logo.
Click on the Import button.
Verify that the list of options appear as per the linked design doc.
Attempt the following for each of the import fields - Departments, Classes, Locations, Customers, Projects
a. Clicking the menu item should open a new page on the RHP.
b. It should contain title corresponding to the field. ex. Departments.
c. It should have the subtitle based on the design doc.
d. For departments, classes, and locations it should show 3 options - NetSuite employee default, Tags and Report field along with the description and a footer based on the selected option. For Customers and Projects, we should only show Tags and Report field.
e. Clicking on each of the options should save the config for the field, and show up in the Import page.
For Projects we have additional toggle on the screen - Cross-subsidiary customers. Clicking should toggle to config?.syncOptions?.crossSubsidiaryCustomers in the policy data.
In case of the API error, there should be an error message below the switch or each of the menu item.

Verify that no errors appear in the JS console

Offline tests

Same as Test steps, with the greyed out menu item in case of optimistic pending updates.

QA Steps

Same as Test Steps.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-netsuite-import-mapping.mov

Android: mWeb Chrome

mweb-chrome-netsuite-import-mapping.mov

iOS: Native

ios-netsuite-import-mapping.mov

iOS: mWeb Safari

mweb-safari-netsuite-import-mapping.mov

MacOS: Chrome / Safari

Happy Flow

web-netsuite-import-mapping_a9uoFduJ.mp4

Spanish Translations and Errors
https://github.com/Expensify/App/assets/3069065/f3ce1aa4-352f-4a37-acec-3dc16824562b

New Screen for Customers / projects

web-customer-jobs-page.mov

MacOS: Desktop

desktop-netsuite-import-mapping.mov

desktop-customer-jobs-page.mov

…-field-pages

…port-field-pages

…-field-pages

…port-field-pages

mananjadhav · 2024-07-04T14:41:24Z

Thanks for the detailed feedback on the design @shubham1206agra. Appreciate it. I've fixed all feedback and here's the revised video.

web-netsuite-import-mapping.mov

…port-field-pages

mananjadhav · 2024-07-04T15:09:57Z

@shubham1206agra I've fixed the content overflowing as well that you reported.

shubham1206agra · 2024-07-04T16:55:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2024-07-04.at.9.51.24.PM.mov

iOS: Native

Screen.Recording.2024-07-04.at.10.03.49.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-07-04.at.9.16.43.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-07-04.at.8.30.39.PM.mov

MacOS: Desktop

Screen.Recording.2024-07-04.at.10.00.09.PM.mov

…port-field-pages

src/CONST.ts

src/libs/PolicyUtils.ts

yuwenmemon · 2024-07-04T20:20:49Z

src/libs/actions/connections/NetSuiteCommands.ts

+            commandName = WRITE_COMMANDS.UPDATE_NETSUITE_CUSTOMERS_MAPPING;
+            break;
+        case 'jobs':
+            commandName = WRITE_COMMANDS.UPDATE_NETSUITE_JOBS_MAPPING;


Just a note is that we'll change these later down the line once we have a new API for this.

OSBotify · 2024-07-04T21:19:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-08T09:58:19Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.5-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-08T10:54:42Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.5-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-07-10T11:06:20Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T20:24:56Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mananjadhav added 30 commits June 30, 2024 15:47

feat: route setup

10cad3e

fix: import field param

9f82a3b

feat: page header with selection list

ede7cc0

feat: populate the list with the options

6d43b7f

feat: added the footer content

2c3923e

Merge branch 'mj-netsuite-import-list-screen' into mj-netsuite-import…

5d6be1c

…-field-pages

Merge branch 'mj-netsuite-import-list-screen' into mj-netsuite-import…

69c36eb

…-field-pages

fix: remove duplicate props

c147736

Merge branch 'main' of github.com:mananjadhav/App into mj-netsuite-im…

dafdea8

…port-field-pages

Merge branch 'mj-netsuite-import-list-screen' into mj-netsuite-import…

94c8da8

…-field-pages

Merge branch 'mj-netsuite-import-list-screen' into mj-netsuite-import…

ffadb40

…-field-pages

feat: added spanish translations

b332bfa

fix: added api commands

e15f141

feat: added api call and fix footer content

bb8bcba

feat: added api call

c82dcb0

refactor: fix types

6d60f4d

refactor: adjusted offline types

7222bac

fix: offline types for syncTax

2cf060a

refactor: run prettier

023b21d

refactor: add pendingFields

168ff6d

fix: rollback menu item key

dc648fb

Merge branch 'mj-netsuite-import-list-screen' into mj-netsuite-import…

af98de0

…-field-pages

refactor: run prettier

ab2359e

refactor: run prettier

6c877b3

feat: added translations

c93a371

refactor: update types

fd265ee

feat: update api calls for cross subsidiary

5c00308

fix: styling overlap

5fa854d

Merge branch 'mj-netsuite-import-list-screen' into mj-netsuite-import…

2281c0b

…-field-pages

Merge branch 'main' of github.com:mananjadhav/App into mj-netsuite-im…

c48176f

…port-field-pages

mananjadhav added 3 commits July 4, 2024 19:55

refactor: design updates

dccc36b

fix: added back

244dff7

fix: field lower case

a661387

refactor: use const

e1d55ce

mananjadhav requested a review from shubham1206agra July 4, 2024 14:53

mananjadhav added 2 commits July 4, 2024 20:31

Merge branch 'main' of github.com:mananjadhav/App into mj-netsuite-im…

b2d59e8

…port-field-pages

fix: truncate

4ebd514

shubham1206agra approved these changes Jul 4, 2024

View reviewed changes

mananjadhav added 3 commits July 4, 2024 23:17

Merge branch 'main' of github.com:mananjadhav/App into mj-netsuite-im…

65ead54

…port-field-pages

fix: back handler

ee5e345

Merge branch 'main' of github.com:mananjadhav/App into mj-netsuite-im…

226b0da

…port-field-pages

yuwenmemon requested changes Jul 4, 2024

View reviewed changes

mananjadhav added 3 commits July 5, 2024 02:06

refactor: rename const

cddfd35

refactor: simplify condition

4608775

refactor: run prettier

3acf1ab

mananjadhav requested a review from yuwenmemon July 4, 2024 20:38

yuwenmemon approved these changes Jul 4, 2024

View reviewed changes

yuwenmemon merged commit 2d5ede8 into Expensify:main Jul 4, 2024
15 checks passed

github-actions bot mentioned this pull request Jul 8, 2024

Deploy Checklist: New Expensify 2024-07-08 #44947

Closed

86 tasks

lanitochka17 mentioned this pull request Jul 9, 2024

[Awaiting Payment 9th August] [$250] Accounting - Accounting isn't enabled in ND if a connection is made in OD #45080

Closed

6 tasks

melvin-bot bot mentioned this pull request Jul 10, 2024

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [#Wave-Control: Add NetSuite] Settings Configuration in NewDot: Import #43437

Closed

yuwenmemon mentioned this pull request Jul 19, 2024

[$4000] Implementing NetSuite Integration in NewDot (mananjadhav) #45805

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#Wave-Control: Add NetSuite]: Settings Configuration in NewDot: Import Mapping #44743

[#Wave-Control: Add NetSuite]: Settings Configuration in NewDot: Import Mapping #44743

mananjadhav commented Jul 2, 2024 •

edited

Loading

mananjadhav commented Jul 4, 2024

mananjadhav commented Jul 4, 2024

shubham1206agra commented Jul 4, 2024

yuwenmemon Jul 4, 2024

OSBotify commented Jul 4, 2024

OSBotify commented Jul 8, 2024

OSBotify commented Jul 8, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 15, 2024

[#Wave-Control: Add NetSuite]: Settings Configuration in NewDot: Import Mapping #44743

[#Wave-Control: Add NetSuite]: Settings Configuration in NewDot: Import Mapping #44743

Conversation

mananjadhav commented Jul 2, 2024 • edited Loading

Details

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

mananjadhav commented Jul 4, 2024

mananjadhav commented Jul 4, 2024

shubham1206agra commented Jul 4, 2024

Reviewer Checklist

Screenshots/Videos

yuwenmemon Jul 4, 2024

Choose a reason for hiding this comment

OSBotify commented Jul 4, 2024

OSBotify commented Jul 8, 2024

OSBotify commented Jul 8, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 15, 2024

mananjadhav commented Jul 2, 2024 •

edited

Loading