[HOLD for payment 2024-07-10] [#Wave-Control: Add NetSuite] Settings Configuration in NewDot: Top-Level Subsidiary Selector

[yuwenmemon]

Tracking Issue: https://github.com/Expensify/Expensify/issues/377671

Design Doc Section: https://docs.google.com/document/d/1WubNv_VAv78IxG4FKsi9aS0pWESfWvUYbqBAAy5b4bc/edit#heading=h.ursdzd4yhqi0

---

(High-Level Section)

Route

• Route: /settings/workspaces/{policyID}/accounting/netsuite/subsidiary
• PageComponent: NetSuiteSubsidiarySelector
• Calls UpdateNetSuiteSubsidiary
  • subsidiaryName: name of the selected subsidiary from options.data.subsidiaryList array.
  • The pendingAction for the OfflineWithFeedback component will be policy.pendingFields.subsidiary

---

We’ll have a NetSuiteSubsidiarySelectorPage, which will populate the list of subsidiaries from the data.subsidiaryList. The sample data shows the list of subsidiaries here.

The basic code for the page will look as follows:

function NetSuiteNetSuiteSubsidiarySelectorPage({policy}: WithPolicyConnectionsProps) {
    const policyID = policy?.id ?? '';

    const { subsidiary } = policy?.connections?.netsuite?.config ?? {};  
    const subsidiaryOptions = useMemo<SelectorType[]>(() => {
        const subsidiaryList = policy?.connections?.netsuite?.options?.data.subsidiaryList ?? {} ?? [];
        const isMatchFound = subsidiaryList?.some(({subsidiaryObj}) => subsidiaryObj === subsidiary); // toLowerCase() ?

        return (subsidiaryList ?? []).map(({id, name}, index) => ({
            value: name,
            text: name,
            keyForList: id,
            isSelected: isMatchFound ? subsidiary === id : index === 0,
        }));
    });

    const listHeaderComponent = useMemo( // Move this to another file as a standalone component.
        () => (
            <View style={[styles.pb2, styles.ph5]}>
                <Text style={[styles.pb5, styles.textNormal]}>{translate('workspace.netsuite.subsidiary.description')}</Text>
            </View>
        ),
        [translate, styles.pb2, styles.ph5, styles.pb5, styles.textNormal],
    );

    const initiallyFocusedOptionKey = useMemo(() => subsidiaryList?.find((subsidiary) => subsidiary.isSelected)?.keyForList, [subsidiaryOptions]);

    const updateSubsidiary = useCallback(
        ({value}: SelectorType) => {
            Connections.updateNetSuiteSubsidiary(policyID, CONST.POLICY.CONNECTIONS.NAME.NET_SUITE, CONST.NET_SUITE_CONFIG, {
                subsidiary: value,
                subsidiaryID: //
            });
            Navigation.goBack(ROUTES.POLICY_ACCOUNTING.getRoute(policyID));
        },
        [policyID],
    );

    return (
        <SelectionScreen
            policyID={policyID}
            accessVariants={[CONST.POLICY.ACCESS_VARIANTS.ADMIN, CONST.POLICY.ACCESS_VARIANTS.PAID]}
            featureName={CONST.POLICY.MORE_FEATURES.ARE_CONNECTIONS_ENABLED}
            displayName={NetSuiteNetSuiteSubsidiarySelectorPage.displayName}
            sections={[{data: subsidiaryOptions}]}
            listItem={RadioListItem}
            onSelectRow={updateSubsidiary}
            initiallyFocusedOptionKey={initiallyFocusedOptionKey}
            headerContent={listHeaderComponent}
            onBackButtonPress={() => Navigation.goBack(ROUTES.POLICY_ACCOUNTING.getRoute(policyID))}
            title="workspace.netsuite.subsidiary.title"
        />
    );
}

NetSuiteNetSuiteSubsidiarySelectorPage.displayName = 'NetSuiteNetSuiteSubsidiarySelectorPage';

export default withPolicyConnections(NetSuiteNetSuiteSubsidiarySelectorPage);

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d62f33ad0e1e9fe6
• Upwork Job ID: 1800281430610989476
• Last Price Increase: 2024-06-10

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d62f33ad0e1e9fe6

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

Current assignee @mananjadhav is eligible for the External assigner, not assigning anyone new.

[yuwenmemon]

Sample NetSuite connection data JSON:
sampleNetSuiteJSON.json

This would go under connections.netsuite in your policy object in Onyx, just like for quickbooksOnline

[mananjadhav]

Starting with this issue first. I'll have the first PR ready by weekend. Might be away on Friday.

[yuwenmemon]

Great! I'll try to prioritize getting the subsidiary selection API out for you in a separate PR then.

[melvin-bot]

@JmillsExpensify, @mananjadhav, @yuwenmemon Eep! 4 days overdue now. Issues have feelings too...

[JmillsExpensify]

@mananjadhav has been sick but we'll be coming back to this one soon.

[mananjadhav]

@yuwenmemon I'll need:

1. To confirm if the API is ready?
2. Can you share the Netsuite Icon?
3. Spanish translation for Subsidiary and Choose the subsidiary in NetSuite that you\'d like to import data from.
4. Name of the beta behind which the Netsuite should be. Because during active development we don't want to show NetSuite right?

[mananjadhav]

Demo video of the list:

web-net-suite-subsidiary-one.mov

[yuwenmemon]

To confirm if the API is ready?

The API to select a subsidiary is live as of an hour ago!

    } elseif ($command === 'UpdateNetSuiteSubsidiary') {
        NetSuite::updateSubsidiary($authToken, $policyID, $_REQUEST['subsidiary'] ?? '');

[yuwenmemon]

Can you share the Netsuite Icon?

Asking this for you here: https://expensify.slack.com/archives/C06ML6X0W9L/p1718836882604659

[yuwenmemon]

Spanish translation for Subsidiary and Choose the subsidiary in NetSuite that you'd like to import data from.

Asking this for you here: https://expensify.slack.com/archives/C21FRDWCV/p1718837580539369

[yuwenmemon]

Name of the beta behind which the Netsuite should be. Because during active development we don't want to show NetSuite right?

Asked this for you here: https://expensify.slack.com/archives/C06ML6X0W9L/p1718837727812639

[yuwenmemon]

Spanish:
Subsidiaria
Elige la subsidiaria de NetSuite de la que deseas importar datos

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [#Wave-Control: Add NetSuite]: Top-level Subsidiary selection #44038

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[mananjadhav]

Payout for this will be centrally paid, no further action here.