[QBO Export] Implement offline pattern B for manual report exports #44733

kosmydel · 2024-07-02T14:16:14Z

HELD on
- Support EXPORTINTEGRATION actions #44930
- https://github.com/Expensify/Web-Expensify/pull/42762

Details

This is a follow-up issue that adds Offline patterns for manual report exports. Until the main PR is merged you can see changes from this PR only using this link.

Fixed Issues

$ #43040

Tests

Sucessful offline export

Submit an expense report
Log in as the workspace admin
Approve the report
Go offline
3-dot menu > Export > Quickbooks Online
Verify a semi-transparent started exporting this report to QuickBooks Online... message shows
Go online
Verify the action becomes fully opaque
Wait a few seconds
Verify the action updates to exported this report to QuickBooks Online. [View out-of-pocket expenses].

Failed offline export

Prerequisites

Add a chart of account (category) to QBO that you can delete later

Steps

Create a report with an expense
Categorize the expense using the new QBO category
Submit it
Log in as the workspace admin and approve the report
Log into QBO and deactivate the chart of account for the category (Menu > Transactions > Chart of accounts > {account} menu > Make inactive)
Go offline in NewDot
Export the report to QBO (3-dot menu > Export > Quickbooks Online)
Verify a semi-transparent started exporting this report to QuickBooks Online... message shows
Go online
Verify the action becomes fully opaque
Wait a few seconds
Verify a report export error message is added the report

Offline tests

Same as Tests

QA Steps

Same as Tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-07-16.at.15.09.04.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-07-16.at.15.05.37.mov

MacOS: Desktop

…-export/manual-exports-offline-patterns

kosmydel · 2024-07-04T08:35:29Z

src/libs/ReportUtils.ts

+function buildOptimisticExportIntegrationAction(label = '', markedManually = false): OptimisticExportAction {
+    return {
+        reportActionID: NumberUtils.rand64(),
+        actionName: CONST.REPORT.ACTIONS.TYPE.EXPORTED_TO_INTEGRATION,
+        pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
+        actorAccountID: currentUserAccountID,
+        message: [],
+        person: [],
+        automatic: false,
+        avatar: getCurrentUserAvatar(),
+        created: DateUtils.getDBTime(),
+        shouldShow: true,
+        originalMessage: {
+            automaticAction: false,
+            label,
+            lastModified: DateUtils.getDBTime(),
+            markedManually,
+        },
+    };
+}
+


Hey, @arosiclair could you have a look and confirm that this is the only action that I need to add when offline? The issue said that, but the backend sends a few more Onyx updates.

If this is the only action, do you know if it has all the required fields?

I managed to reverse-engineer it from the backend response, but it would be great to have confirmation.

Yeah this should be the only new action added and the data looks good so far.

I updated the issue here btw. We'll still add this optimistic action, but the text needs to be different while it's optimistic. We should be able to control that here.

Just want to make sure: we want to leave this action in the old dot report actions section?

Yeah that should be fine for now

Actually, I have to work on the EXPORTINTEGRATION action in this PR first. So we should just control the copy in the new ExportIntegration component.

Should this issue be held on #44930 as well?

Seems #44930 is close to merge 👀

…-export/manual-exports-offline-patterns

kosmydel · 2024-07-16T10:19:15Z

src/languages/en.ts

+                exportedToIntegration: ({label, markedManually}: ExportedToIntegrationParams) => {
+                    if (markedManually) {
+                        // TODO: Verify translation - it was taken from the backend response, and it is needed here for the optimistic response
+                        return `You marked this report as manually exported to`;
+                    }
+                    return `exported this report to ${CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[label] ?? label}`;
+                },
+                exportInProgress: ({label}: ExportedToIntegrationParams) => `started exporting this report to ${CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[label] ?? label}...`,


Those translations need to be verified.

kosmydel · 2024-07-16T11:16:35Z

There might be something wrong with the backend responses. The manual export requests don't update automatically after reconnecting. After refreshing the page I can see 2 actions coming from the backend.

Screen.Recording.2024-07-16.at.13.13.31.mov

melvin-bot · 2024-07-16T13:11:46Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…patterns

hungvu193 · 2024-07-16T16:17:31Z

Can you merge this with latest main? @kosmydel

kosmydel · 2024-07-16T16:18:52Z

Can you merge this with latest main? @kosmydel

Yeah, I've already done it :D

arosiclair · 2024-07-16T16:26:29Z

We should wait for #44930 to get merged so that these actions display correctly.

There might be something wrong with the backend responses. The manual export requests don't update automatically after reconnecting. After refreshing the page I can see 2 actions coming from the backend.

I still need to draft changes to support this on the backend. I'll get started on that today

hungvu193

LGTM! (I can't upload few screenshots due to some internet connection issue, I'll update them later in the morning).

Update: Completed all the screenshots/videos.

hungvu193 · 2024-07-26T04:15:08Z

There's an issue with Pusher data I think, the result of export data will never show up until you visit that report once again.
It was working fine yesterday when I first tested it.

Screen.Recording.2024-07-26.at.11.13.46.mov

war-in · 2024-07-26T10:14:22Z

cc @arosiclair 👆

arosiclair · 2024-07-26T14:18:36Z

@hungvu193 you have to test with a QBO connection. Xero does not support pattern B yet. Also you should expect the export to succeed and the started exporting to QuickBooks Online... message should be replaced with the exported this report to QBO message instead of showing up as a separate one.

Can you retest?

hungvu193 · 2024-07-26T14:22:24Z

~~Ah yes, Xero export is working as expected~~

I mean sometimes it's working even with Xero. Let me test with QBO

Screen.Recording.2024-07-25.at.18.02.40.mov

hungvu193 · 2024-07-26T14:34:30Z

@arosiclair I've just tested with QBO, I can't receive Pusher update for export report result.

Screen.Recording.2024-07-26.at.21.29.54.mov

hungvu193 · 2024-07-26T14:40:46Z

Can you please trigger the build here?

trjExpensify · 2024-07-26T15:01:11Z

Building.

github-actions · 2024-07-26T15:35:19Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/44733/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/44733/NewExpensify.dmg	https://44733.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

arosiclair · 2024-07-26T18:20:46Z

I mean sometimes it's working even with Xero. Let me test with QBO

Pattern B is not working correctly if started... and exported messages appear separately here. I updated the test steps to verify that. Make sure that works correctly with QBO please 🙏

@arosiclair I've just tested with QBO, I can't receive Pusher update for export report result.

If it's still not exporting successfully, can you share the requestID for the Report_Export command? You can get it in the response from dev tools.

hungvu193 · 2024-07-29T01:55:42Z

If it's still not exporting successfully, can you share the requestID for the Report_Export command? You can get it in the response from dev tools.

Here you are: 8aa979e0ab3b85b2-HKG

Here's the cURL in case you need it:

cURL

curl 'https://dev.new.expensify.com:8082/api/Report_Export?' \
  -H 'Accept: */*' \
  -H 'Accept-Language: en-US,en;q=0.9' \
  -H 'Connection: keep-alive' \
  -H 'Content-Type: multipart/form-data; boundary=----WebKitFormBoundary06cD0MPYlWlTh4x6' \
  -H 'Cookie: initialReferer=%28direct%29; browserGUID=653888c049509; mutiny.user.token=44271853-1d21-40d9-9708-52c3488dccc2; _gcl_au=1.1.1997638827.1716280514; _ga_GR0HGLT8QC=GS1.2.1716280514.5.1.1716280535.39.0.0; fs_cid=1.1; _ga_JN0QG4EC3H=GS1.2.1720511043.2.0.1720511043.60.0.0; AMCV_98CF678254E93B1B0A4C98A5%40AdobeOrg=179643557%7CMCMID%7C18503322733917679562200117914871702674%7CMCAAMLH-1721115844%7C3%7CMCAAMB-1721115844%7C6G1ynYcLPuiQxYZrsz_pkqfLG9yMXBpb2zX5dvJdYQJzPXImdj0y%7CMCOPTOUT-1720518244s%7CNONE%7CvVersion%7C5.5.0; _ga_PNQ04Q4SFF=GS1.2.1720665626.1.1.1720666987.60.0.0; _ga=GA1.1.1392566190.1709532684; onfido-web-sdk-analytics=4ece8e2a-feb6-4445-ae5d-92097385485b; cf_clearance=E.dN7s6jqZ0FJIRTRTV55Gnm2JcjSQ5QV98e3CInL4o-1721899523-1.0.1.1-hPZSaeqGbiv720b9H9oEOMaRx0kETiffiNtBfbVbGjtbbYatlZfWdkxRBWB1gEHeOBTE78oB6l_xGV9JTrSAEA; _clck=1brb4ho%7C2%7Cfnr%7C0%7C1640; _uetvid=ee01f610353b11ef8f28c919fee6a33f; _ga_6BR2QJRCCD=GS1.1.1721902395.17.0.1721902395.60.0.0; fs_uid=#o-1WN56P-na1#bf579a4d-f5be-46e8-8fed-4ffb247ea8a7:7cafb27f-ba85-484b-999e-324705d96274:1721964928589::1#a73a1961#/1749626460; __cf_bm=vpwUtixxTeWNmZLzBSTHTX4hdQY3qAV9XwiX4et3Cp4-1722217806-1.0.1.1-WFiYYn9VXtxbBgIw1sw.Ewx7bhrTMM1mYF6mCypC61o5PNrbCmop.Af4492qkoHvsZAItnUnQNeVnf2gh06d9w; _cfuvid=buXapMIr.uHwcS.MGtSQEceocwEd53k7eZoyApGULgk-1722217806724-0.0.1.1-604800000' \
  -H 'Origin: https://dev.new.expensify.com:8082' \
  -H 'Referer: https://dev.new.expensify.com:8082/r/6403319933559642' \
  -H 'Sec-Fetch-Dest: empty' \
  -H 'Sec-Fetch-Mode: cors' \
  -H 'Sec-Fetch-Site: same-origin' \
  -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.0.0 Safari/537.36' \
  -H 'sec-ch-ua: "Not/A)Brand";v="8", "Chromium";v="126", "Google Chrome";v="126"' \
  -H 'sec-ch-ua-mobile: ?0' \
  -H 'sec-ch-ua-platform: "macOS"' \
  --data-raw $'------WebKitFormBoundary06cD0MPYlWlTh4x6\r\nContent-Disposition: form-data; name="reportIDList"\r\n\r\n6403319933559642\r\n------WebKitFormBoundary06cD0MPYlWlTh4x6\r\nContent-Disposition: form-data; name="connectionName"\r\n\r\nquickbooksOnline\r\n------WebKitFormBoundary06cD0MPYlWlTh4x6\r\nContent-Disposition: form-data; name="type"\r\n\r\nMANUAL\r\n------WebKitFormBoundary06cD0MPYlWlTh4x6\r\nContent-Disposition: form-data; name="optimisticReportActions"\r\n\r\n{"6403319933559642":"5953812755179798095"}\r\n------WebKitFormBoundary06cD0MPYlWlTh4x6\r\nContent-Disposition: form-data; name="apiRequestType"\r\n\r\nwrite\r\n------WebKitFormBoundary06cD0MPYlWlTh4x6\r\nContent-Disposition: form-data; name="pusherSocketID"\r\n\r\n753965.1528538\r\n------WebKitFormBoundary06cD0MPYlWlTh4x6\r\nContent-Disposition: form-data; name="shouldRetry"\r\n\r\ntrue\r\n------WebKitFormBoundary06cD0MPYlWlTh4x6\r\nContent-Disposition: form-data; name="canCancel"\r\n\r\ntrue\r\n------WebKitFormBoundary06cD0MPYlWlTh4x6\r\nContent-Disposition: form-data; name="authToken"\r\n\r\n491BBB6BE109CB52F429E640C1AF60BD166B92E96FC9A9E05CF0FC146F782D776ED6F8A6A61EB54FB5DE8FF11AB952F03D84E58A810878C2CA796DC3583C1318C1C90D3EA660BC03789373E4186592238838BB0F39C17E648DC66DACF74E78C71229DABDBFFA797D3C1ABDE7322FC2C25C423638BDCB15BF9178767E3FB141EF780076F1E53240F6919CA31514C3C2DC40ECA3A229CA9613CD52FD82E516C6F5580E33E2896DF9AE85BC0D6A08BA9D97930EF2CE3486BC2F66AFDBC8EB88B724D54E3EEDC50F5B386A991DEA63E7212EC370D16339749CBC910BBC164D7F23F6FAEB007A396C791E3339061CA351DDA4F933725E59CEA2C8A231DF45C3A61E5D79A5378D943524C6BC4F0EA1EB15BE00E9BCD615FF9C5E2E9D2D4A4F23F8DF5CC58F2DAFF1DA988D849E4B01176612C5373753119BB6BE269DE92D4165EC067272D8AFD8052945EC42F7E84552B6D172CF57EC8F7259EC978B428C774163C69D\r\n------WebKitFormBoundary06cD0MPYlWlTh4x6\r\nContent-Disposition: form-data; name="referer"\r\n\r\necash\r\n------WebKitFormBoundary06cD0MPYlWlTh4x6\r\nContent-Disposition: form-data; name="platform"\r\n\r\nweb\r\n------WebKitFormBoundary06cD0MPYlWlTh4x6\r\nContent-Disposition: form-data; name="api_setCookie"\r\n\r\nfalse\r\n------WebKitFormBoundary06cD0MPYlWlTh4x6\r\nContent-Disposition: form-data; name="email"\r\n\r\[email protected]\r\n------WebKitFormBoundary06cD0MPYlWlTh4x6\r\nContent-Disposition: form-data; name="isFromDevEnv"\r\n\r\ntrue\r\n------WebKitFormBoundary06cD0MPYlWlTh4x6\r\nContent-Disposition: form-data; name="appversion"\r\n\r\n9.0.12-0\r\n------WebKitFormBoundary06cD0MPYlWlTh4x6\r\nContent-Disposition: form-data; name="clientUpdateID"\r\n\r\n731484111\r\n------WebKitFormBoundary06cD0MPYlWlTh4x6--\r\n'

arosiclair · 2024-07-29T14:26:49Z

I see

Could not find QuickBooks vendor

Hmm.. we're unable to find a QuickBooks vendor for [email protected]. Don't worry, just enable Automatic Entity Creation and you'll never run into this error again! Alternatively, you can resolve this issue by logging into QuickBooks, associating an email address with the appropriate vendor, and then exporting again

Are you able to sync your QBO connection successfully? Try to do it from OldDot (Settings > Workspaces > Group > {policy} > Connections). Try that and try following the instructions from the above error messages if it still doesn't work. If you're still having trouble, start a thread in #wave-collect and I'll help you debug though it's a little difficult with our timezone difference.

hungvu193 · 2024-07-29T14:35:01Z

Sure. Let me give it a try

hungvu193 · 2024-07-29T15:38:50Z

@arosiclair Awesome! I can export data to QBO successfully. I need to enable Automatically Create Entities from OldDot. I just wonder why we don't add that option into ND?

Screen.Recording.2024-07-29.at.22.37.21.mov

hungvu193 · 2024-07-29T15:56:13Z

so I think this one will be ready for your final review @arosiclair

OSBotify · 2024-07-29T16:36:48Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

trjExpensify · 2024-07-29T18:54:01Z

I need to enable Automatically Create Entities from OldDot. I just wonder why we don't add that option into ND?

This setting should exist on ND under the Advanced tab. :)

trjExpensify · 2024-07-29T18:55:14Z

I am curious why we aren't showing an error on export in the report comments though. Asked about that here.

OSBotify · 2024-07-29T19:30:13Z

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.0.14-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

hungvu193 · 2024-07-30T02:58:09Z

I am curious why we aren't showing an error on export in the report comments though. Asked about that here.

It threw errors with other accounts, but I'm not sure why it didn't with this account, I also can't even log in to OldDot with this account.

arosiclair · 2024-07-30T13:24:08Z

I am curious why we aren't showing an error on export in the report comments though. Asked about that here.

I see it here:

trjExpensify · 2024-07-30T13:47:36Z

Ah okay, cool. Sounded like from Hans that wasn't showing.

roryabraham · 2024-07-31T16:25:23Z

Just as a heads-up to everyone. This one was a QA fail: #46436 (comment). It wasn't reverted because it doesn't appear to cause a regression. It just didn't appear to fix the original issue.

OSBotify · 2024-07-31T19:40:08Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.14-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kosmydel added 4 commits July 2, 2024 16:14

feat: add offline pattern B for manual report exports

7ad0af4

Merge branch '@kosmydel/qbo-export/manual-exports' into @kosmydel/qbo…

8d1f659

…-export/manual-exports-offline-patterns

Merge branch '@kosmydel/qbo-export/manual-exports' into @kosmydel/qbo…

deba812

…-export/manual-exports-offline-patterns

cleanup

533097a

kosmydel commented Jul 4, 2024

View reviewed changes

kosmydel added 10 commits July 4, 2024 11:03

Merge branch '@kosmydel/qbo-export/manual-exports' into @kosmydel/qbo…

5f448b8

…-export/manual-exports-offline-patterns

fix: rbr

1425235

feat: add in progress status

652ce36

Merge branch '@kosmydel/qbo-export/manual-exports' into @kosmydel/qbo…

5f85e77

…-export/manual-exports-offline-patterns

Merge branch '@kosmydel/qbo-export/manual-exports' into @kosmydel/qbo…

a2a1c41

…-export/manual-exports-offline-patterns

Merge branch '@kosmydel/qbo-export/manual-exports' into @kosmydel/qbo…

afcee83

…-export/manual-exports-offline-patterns

fix lang

42b923c

Merge branch '@kosmydel/qbo-export/manual-exports' into @kosmydel/qbo…

eefd928

…-export/manual-exports-offline-patterns

fixes

98c7443

Merge branch '@kosmydel/qbo-export/manual-exports' into @kosmydel/qbo…

1d2e00c

…-export/manual-exports-offline-patterns

kosmydel commented Jul 16, 2024

View reviewed changes

cleanup

972f910

add DeepL translations

37a7735

kosmydel marked this pull request as ready for review July 16, 2024 13:11

kosmydel requested review from a team as code owners July 16, 2024 13:11

melvin-bot bot removed the request for review from a team July 16, 2024 13:11

melvin-bot bot requested a review from hungvu193 July 16, 2024 13:11

Merge branch 'main' into @kosmydel/qbo-export/manual-exports-offline-…

8cbf964

…patterns

arosiclair changed the title ~~[QBO Export] Implement offline pattern B for manual report exports~~ [HOLD][QBO Export] Implement offline pattern B for manual report exports Jul 16, 2024

hungvu193 approved these changes Jul 25, 2024

View reviewed changes

melvin-bot bot requested a review from arosiclair July 25, 2024 15:50

trjExpensify added the Ready To Build label Jul 26, 2024

arosiclair approved these changes Jul 29, 2024

View reviewed changes

arosiclair merged commit 914491a into Expensify:main Jul 29, 2024
18 checks passed

github-actions bot mentioned this pull request Jul 29, 2024

Deploy Checklist: New Expensify 2024-07-29 #46436

Closed

84 tasks

tgolen mentioned this pull request Jul 29, 2024

[Waiting on Checklist - HOLD for payment 2024-11-05] [$250] QBO - Connection options are missing in QBO connection #46445

Closed

6 tasks

[QBO Export] Implement offline pattern B for manual report exports #44733

[QBO Export] Implement offline pattern B for manual report exports #44733

Conversation

kosmydel commented Jul 2, 2024 • edited by arosiclair Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

kosmydel Jul 4, 2024

Choose a reason for hiding this comment

arosiclair Jul 4, 2024

Choose a reason for hiding this comment

kosmydel Jul 5, 2024

Choose a reason for hiding this comment

arosiclair Jul 5, 2024

Choose a reason for hiding this comment

arosiclair Jul 5, 2024

Choose a reason for hiding this comment

kosmydel Jul 16, 2024

Choose a reason for hiding this comment

hungvu193 Jul 16, 2024 • edited Loading

Choose a reason for hiding this comment

kosmydel Jul 16, 2024

Choose a reason for hiding this comment

kosmydel commented Jul 16, 2024

melvin-bot bot commented Jul 16, 2024

hungvu193 commented Jul 16, 2024

kosmydel commented Jul 16, 2024

arosiclair commented Jul 16, 2024 • edited Loading

hungvu193 left a comment • edited Loading

Choose a reason for hiding this comment

hungvu193 commented Jul 26, 2024

war-in commented Jul 26, 2024 • edited Loading

arosiclair commented Jul 26, 2024

hungvu193 commented Jul 26, 2024 • edited Loading

hungvu193 commented Jul 26, 2024

hungvu193 commented Jul 26, 2024

trjExpensify commented Jul 26, 2024

github-actions bot commented Jul 26, 2024

arosiclair commented Jul 26, 2024

hungvu193 commented Jul 29, 2024

arosiclair commented Jul 29, 2024 • edited Loading

hungvu193 commented Jul 29, 2024

hungvu193 commented Jul 29, 2024 • edited Loading

hungvu193 commented Jul 29, 2024

OSBotify commented Jul 29, 2024

trjExpensify commented Jul 29, 2024

trjExpensify commented Jul 29, 2024

OSBotify commented Jul 29, 2024

hungvu193 commented Jul 30, 2024

arosiclair commented Jul 30, 2024

trjExpensify commented Jul 30, 2024

roryabraham commented Jul 31, 2024

OSBotify commented Jul 31, 2024

kosmydel commented Jul 2, 2024 •

edited by arosiclair

Loading

hungvu193 Jul 16, 2024 •

edited

Loading

arosiclair commented Jul 16, 2024 •

edited

Loading

hungvu193 left a comment •

edited

Loading

war-in commented Jul 26, 2024 •

edited

Loading

hungvu193 commented Jul 26, 2024 •

edited

Loading

arosiclair commented Jul 29, 2024 •

edited

Loading

hungvu193 commented Jul 29, 2024 •

edited

Loading