[Waiting on Checklist - HOLD for payment 2024-11-05] [$250] QBO - Connection options are missing in QBO connection

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.14-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Log in to the app with a new expensifail account
2. Create a new workspace
3. Go to more features > enable accounting
4. Navigate to the accountings page and connect with QBO
5. When you are navigated to the QBO page enter the credentials and finish the connection
6. After connecting with QBO, you will be navigated to the app
7. Wait for the connection to sync

Expected Result:

QBO options (Import, Export, Card reconciliation and Advanced options) are displayed

Actual Result:

QBO options (Import, Export, Card reconciliation, and Advanced options) are not displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6556582_1722281658856.2024-07-29_22_24_02.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @ishpaul777

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021841525897082466980
• Upwork Job ID: 1841525897082466980
• Last Price Increase: 2024-10-09
• Automatic offers:
• ishpaul777 | Reviewer | 104412598

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[tgolen]

@kosmydel @hungvu193 @arosiclair Is it possible this is related to #44733 ?

[arosiclair]

I don't think so. Those changes should only affect report exports.

[chiragsalian]

Not a web-e blocker as discussed here

[tgolen]

Sounds like @yuwenmemon might know what's happened here and he will be looking into it.

[yuwenmemon]

Weird, not able to reproduce this in Dev

[yuwenmemon]

Oh I see it now. @NikkiWines it looks like this is because we initially set the lastSync isConnected property to false:
https://github.com/Expensify/Integration-Server/commit/a4cca1bb4863dfcbe9c566cbeeaa47d5676c8c72#diff-49d9c0cf9775a8c0d9890e99f5085ddbed36dbe92d1d8ec3a3956e50d5d9a555R27

[yuwenmemon]

I think this will need to be fixed via the IS.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[hungvu193]

PR is ready!

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.54-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• QBO: Fix connection missing #50766

If no regressions arise, payment will be issued on 2024-11-05. 🎊

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment through NewDot Manual Requests
• @ishpaul777 requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hungvu193 / @ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
• [@hungvu193 / @ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@hungvu193 / @ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@hungvu193 / @ishpaul777] Determine if we should create a regression test for this bug.
• [@hungvu193 / @ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[twisterdotcom]

Payment Summary:

• @hungvu193 paid $250 via NewDot Manual Request
• @ishpaul777 paid $250 here (Reviewer) (Waiting on Checklist)

[garrettmknight]

@hungvu193 please complete the checklist

[ishpaul777]

Will fill checklist today 👍

[ishpaul777]

I am on it now, sorry for delay

[ishpaul777]

i keep on distracting with other tasks and i am on limited availability i swear am on it 🙇

Edit: Done filled it finally 👍

[ishpaul777]

BugZero Checklist:

• [@ishpaul777 ] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other: Not a bug, but a race condition side effect on how new connection with Onyx updates works.

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other: Reported on staging as DB, but was also reproducable on production by folks

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: No specific PR in E/App this was like this since the connection api is implemented on BE PR (i dont have access to BE repo)

• [@ishpaul777] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: Not critical there was only mili second difference and the options show up, It does not block any user flow

• [@ishpaul777] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. No need, same reason as above

[garrettmknight]

$250 approved for @hungvu193

[ishpaul777]

This is not yet paid for me on upwork @twisterdotcom

[twisterdotcom]

Weird, that didn't show up in Upwork for me at all. All done now.